[Toolbar] Base toolbar button class with background images for button states

ui/views/controls/button/label_button.h

Index: ui/views/controls/button/label_button.h
diff --git a/ui/views/controls/button/label_button.h b/ui/views/controls/button/label_button.h
index c69ea037b1068db7934a1ab1528d7cc6c529a191..02446314c89730c83a68234654448739669d53fd 100644
--- a/ui/views/controls/button/label_button.h
+++ b/ui/views/controls/button/label_button.h
@@ -72,6 +72,7 @@ class VIEWS_EXPORT LabelButton : public CustomButton,
 
  protected:
    Label* label() const { return label_; }
+   ImageView* image() const { return image_; }

[Peter Kasting, 2013/11/19 02:28:50]

Nit: Put this above label() to match the member declaration order.

Also, neither of these functions should be const, since they return non-const
pointers.

[Greg Billock, 2013/11/20 00:59:03]

Yeah, you're probably right there. I mean technically they can but I'll bet they
can just return const X*.

[Peter Kasting, 2013/11/20 01:10:20]

Bonus points if you get them to return const X* instead of X*.

[Greg Billock, 2013/11/20 01:30:46]

:-) yeah. I realized even what I want to do with the site chip view won't allow
that. We may be able to get rid of const through, or have a const/non-const pair
if there's enough good const usage.

 
   // Fill |params| with information about the button.
   virtual void GetExtraParams(ui::NativeTheme::ExtraParams* params) const;