[Toolbar] Base toolbar button class with background images for button states

ui/views/controls/button/label_button.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_CONTROLS_BUTTON_LABEL_BUTTON_H_
 #define UI_VIEWS_CONTROLS_BUTTON_LABEL_BUTTON_H_
 
 #include "base/compiler_specific.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include "ui/gfx/font.h"
@@ skipping 54 matching lines @@
   ButtonStyle style() const { return style_; }
   void SetStyle(ButtonStyle style);
 
   // Overridden from View:
   virtual gfx::Size GetPreferredSize() OVERRIDE;
   virtual void Layout() OVERRIDE;
   virtual const char* GetClassName() const OVERRIDE;
 
  protected:
    Label* label() const { return label_; }
+   ImageView* image() const { return image_; }

[Peter Kasting, 2013/11/19 02:28:50]

Nit: Put this above label() to match the member declaration order.

Also, neither of these functions should be const, since they return non-const
pointers.

[Greg Billock, 2013/11/20 00:59:03]

Yeah, you're probably right there. I mean technically they can but I'll bet they
can just return const X*.

[Peter Kasting, 2013/11/20 01:10:20]

Bonus points if you get them to return const X* instead of X*.

[Greg Billock, 2013/11/20 01:30:46]

:-) yeah. I realized even what I want to do with the site chip view won't allow
that. We may be able to get rid of const through, or have a const/non-const pair
if there's enough good const usage.

 
   // Fill |params| with information about the button.
   virtual void GetExtraParams(ui::NativeTheme::ExtraParams* params) const;
 
   // Resets colors from the NativeTheme, explicitly set colors are unchanged.
   virtual void ResetColorsFromNativeTheme();
 
   // Updates the image view to contain the appropriate button state image.
   void UpdateImage();
 
@@ skipping 45 matching lines @@
 
   // The button's overall style.
   ButtonStyle style_;
 
   DISALLOW_COPY_AND_ASSIGN(LabelButton);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_CONTROLS_BUTTON_LABEL_BUTTON_H_