Make sure there are no errors when compiling V8 using VS2005 project files....

src/ia32/lithium-gap-resolver-ia32.cc

Index: src/ia32/lithium-gap-resolver-ia32.cc
===================================================================
--- src/ia32/lithium-gap-resolver-ia32.cc	(revision 6654)
+++ src/ia32/lithium-gap-resolver-ia32.cc	(working copy)
@@ -31,14 +31,20 @@
 namespace v8 {
 namespace internal {
 
-LGapResolver::LGapResolver(LCodeGen* owner)
+#ifdef _MSC_VER
+    #pragma warning(push)
+    #pragma warning(disable : 4351)
+#endif  // _MSC_VER

[William Hesse, 2011/02/05 19:38:12]

Can't we disable the warning as a setting in the VS 2005 project file, without
inserting #pragma lines in the source.  I don't think we want to allow this, and
we might choose to initialize these explicitly rather than have to add the
pragma.
We disabled the warning in the SCons and the gyp builds, I think.

+    LGapResolver::LGapResolver(LCodeGen* owner)
     : cgen_(owner),
       moves_(32),
       source_uses_(),
       destination_uses_(),
       spilled_register_(-1) {}
+#ifdef _MSC_VER
+    #pragma warning(pop)
+#endif  // _MSC_VER
 
-
 void LGapResolver::Resolve(LParallelMove* parallel_move) {
   ASSERT(HasBeenReset());
   // Build up a worklist of moves.