Chromium Code Reviews
Help | Chromium Project | Sign in
(73)

Issue 6286135: Make sure there are no errors when compiling V8 using VS2005 project files.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 1 month ago by Xu Liu
Modified:
3 years, 10 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Make sure there are no errors when compiling V8 using VS2005 project files. bignum.cc Add some static_cast to avoid type-casting warnings. profile-generator.cc VS2005 will show an warning message if the Windows "Language for non-Unicode programs" setting is not "English". Change Non-ASCII Characters to "-" in Line 2288. common.vsprops Add "4351" to "DisableSpecificWarnings" because there is "Compiler Warning C4351" in lithium-gap-resolver-ia32.cc BUG=V8:898 TEST=Use VS2005+SP1 to build v8.sln successfully. Committed at r6706 to bleeding-edge.

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M src/bignum.cc View 1 4 chunks +6 lines, -5 lines 0 comments Download
M src/profile-generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/visual_studio/common.vsprops View 1 1 chunk +1 line, -1 line 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 4 (0 generated)
Xu Liu
The change list is used to fix V8 Issue 898 http://code.google.com/p/v8/issues/detail?id=898
4 years, 1 month ago (2011-02-05 09:29:50 UTC) #1
William Hesse
I don't think we want to put #pragma lines in the source. See comment. So ...
4 years, 1 month ago (2011-02-05 19:38:12 UTC) #2
Xu Liu
You are right - the warning C4351 in the SCons and the gyp builds is ...
4 years, 1 month ago (2011-02-06 13:21:29 UTC) #3
William Hesse
4 years, 1 month ago (2011-02-09 15:45:01 UTC) #4
LGTM, except for two tabs in VSProps file.  I will commit it for you.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cf4c24d