Make sure there are no errors when compiling V8 using VS2005 project files....

src/ia32/lithium-gap-resolver-ia32.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 13 matching lines @@
 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 #include "ia32/lithium-gap-resolver-ia32.h"
 #include "ia32/lithium-codegen-ia32.h"
 
 namespace v8 {
 namespace internal {
 
-LGapResolver::LGapResolver(LCodeGen* owner)
+#ifdef _MSC_VER
+    #pragma warning(push)
+    #pragma warning(disable : 4351)
+#endif  // _MSC_VER

[William Hesse, 2011/02/05 19:38:12]

Can't we disable the warning as a setting in the VS 2005 project file, without
inserting #pragma lines in the source.  I don't think we want to allow this, and
we might choose to initialize these explicitly rather than have to add the
pragma.
We disabled the warning in the SCons and the gyp builds, I think.

+    LGapResolver::LGapResolver(LCodeGen* owner)
     : cgen_(owner),
       moves_(32),
       source_uses_(),
       destination_uses_(),
       spilled_register_(-1) {}
-
+#ifdef _MSC_VER
+    #pragma warning(pop)
+#endif  // _MSC_VER
 
 void LGapResolver::Resolve(LParallelMove* parallel_move) {
   ASSERT(HasBeenReset());
   // Build up a worklist of moves.
   BuildInitialMoveList(parallel_move);
 
   for (int i = 0; i < moves_.length(); ++i) {
     LMoveOperands move = moves_[i];
     // Skip constants to perform them last.  They don't block other moves
     // and skipping such moves with register destinations keeps those
@@ skipping 400 matching lines @@
     // Compute those counts now.
     source_uses_[source->index()] = CountSourceUses(source);
   } else if (destination->IsRegister()) {
     source_uses_[destination->index()] = CountSourceUses(destination);
   }
 }
 
 #undef __
 
 } }  // namespace v8::internal