Make sure there are no errors when compiling V8 using VS2005 project files....

Make sure there are no errors when compiling V8 using VS2005 project files.
bignum.cc
Add some static_cast to avoid type-casting warnings.

profile-generator.cc
VS2005 will show an warning message if the Windows "Language for non-Unicode programs" setting is not "English". Change Non-ASCII Characters to "-" in Line 2288. 

common.vsprops
Add "4351" to "DisableSpecificWarnings" because there is "Compiler Warning C4351" in lithium-gap-resolver-ia32.cc

BUG=V8:898
TEST=Use VS2005+SP1 to build v8.sln successfully.

Committed at r6706 to bleeding-edge.

[Xu Liu, 2011-02-05 09:29:50]

The change list is used to fix V8 Issue 898
http://code.google.com/p/v8/issues/detail?id=898

[William Hesse, 2011-02-05 19:38:12]

I don't think we want to put #pragma lines in the source.  See comment.
So we need to find another way to disable the warning.

http://codereview.chromium.org/6286135/diff/1/src/bignum.cc
File src/bignum.cc (right):

http://codereview.chromium.org/6286135/diff/1/src/bignum.cc#newcode752
src/bignum.cc:752: static_cast<Chunk>(bigits_[i + exponent_diff] - (remove &
kBigitMask));
Can this static_cast<Chunk> be applied just to (remove & kBigitMask), instead of
the whole expression?

http://codereview.chromium.org/6286135/diff/1/src/ia32/lithium-gap-resolver-i...
File src/ia32/lithium-gap-resolver-ia32.cc (right):

http://codereview.chromium.org/6286135/diff/1/src/ia32/lithium-gap-resolver-i...
src/ia32/lithium-gap-resolver-ia32.cc:37: #endif  // _MSC_VER
Can't we disable the warning as a setting in the VS 2005 project file, without
inserting #pragma lines in the source.  I don't think we want to allow this, and
we might choose to initialize these explicitly rather than have to add the
pragma.
We disabled the warning in the SCons and the gyp builds, I think.

http://codereview.chromium.org/6286135/diff/1/src/profile-generator.cc
File src/profile-generator.cc (right):

http://codereview.chromium.org/6286135/diff/1/src/profile-generator.cc#newcod...
src/profile-generator.cc:2288: // Softw. Pract. Exper. 4 (2001), pp. 1-10.
Good.

[Xu Liu, 2011-02-06 13:21:29]

You are right - the warning C4351 in the SCons and the gyp builds is disabled
(SConstruct has 'WARNINGFLAGS': ['/W3', '/WX', '/wd4351', '/wd4355', '/wd4800']
and v8.gyp has 'msvs_disabled_warnings': [4351, 4355, 4800]). I have reverted
lithium-gap-resolver-ia32.cc, and changed common.vsprops to disable warning 4351
(but it means warning 4351 is disabled in the whole project, not specific
codes).

And I have changed bignum.cc as you suggested. Thank you.

[William Hesse, 2011-02-09 15:45:01]

LGTM, except for two tabs in VSProps file.  I will commit it for you.