Issue 62853002: remove CHECK in RemoteRootWindowHostWin::Disconnected

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 62853002: remove CHECK in RemoteRootWindowHostWin::Disconnected (Closed)

Created:
7 years, 1 month ago by scottmg

Modified:
7 years, 1 month ago

Reviewers:
cpu_(ooo_6.6-7.5), sky

CC:
chromium-reviews, sadrul, ben+aura_chromium.org, kalyank

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

remove CHECK in RemoteRootWindowHostWin::Disconnected This was triggered by the change to restart in desktop mode when running with the software compositor. But in general, it's possible for a channel error to happen before SetTargetSurface which sets the host_. Since the CHECK isn't accomplishing too much, just remove it. R=cpu@chromium.org, sky@chromium.org BUG=315057 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233437

Patch Set 1 #

Total comments: 1

Patch Set 2 : comment #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	ui/aura/remote_root_window_host_win.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/62853002/diff/1/ui/aura/remote_root_window_host_win.cc File ui/aura/remote_root_window_host_win.cc (left): https://codereview.chromium.org/62853002/diff/1/ui/aura/remote_root_window_host_win.cc#oldcode153 ui/aura/remote_root_window_host_win.cc:153: CHECK(host_ != NULL); Please add a comment that ...

7 years, 1 month ago (2013-11-06 21:28:48 UTC) #4

scottmg

7 years, 1 month ago (2013-11-07 00:38:18 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r233437 (presubmit successful).

Expand Messages | Collapse Messages