ui/aura/remote_root_window_host_win.cc - Issue 62853002: remove CHECK in RemoteRootWindowHostWin::Disconnected

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/aura/remote_root_window_host_win.cc

Issue 62853002: remove CHECK in RemoteRootWindowHostWin::Disconnected (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: comment Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/aura/remote_root_window_host_win.cc

diff --git a/ui/aura/remote_root_window_host_win.cc b/ui/aura/remote_root_window_host_win.cc

index 3e7837b39c294dcac8370f6b4ddeaedcb16dd9ed..2b575c4d8eab9bc62e2a44b0c446441479832a81 100644

--- a/ui/aura/remote_root_window_host_win.cc

+++ b/ui/aura/remote_root_window_host_win.cc

@@ -150,7 +150,8 @@ void RemoteRootWindowHostWin::Connected(IPC::Sender* host, HWND remote_window) {

}

void RemoteRootWindowHostWin::Disconnected() {

- CHECK(host_ != NULL);

+ // Don't CHECK here, Disconnected is called on a channel error which can

+ // happen before we're successfully Connected.

host_ = NULL;

remote_window_ = NULL;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »