Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 628523002: WebRTC: Prepare for enabling bot_update for standalone recipe. (Closed)

Created:
6 years, 2 months ago by kjellander_chromium
Modified:
6 years, 2 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Project:
tools
Visibility:
Public.

Description

WebRTC: Prepare for enabling bot_update for standalone recipe. Add the bot_update step but keep bot_update disabled for now. The 'client.webrtc' waterfall was currently enabled in bot_update.py since we used to have Android APK builders that were based on a Chromium checkout (and thus had to run bot_update before the Chromium Git switch). These bots now builds from a standalone WebRTC checkout and thus we'll re-enable bot_update for client.webrtc when a series of dependent CLs are landed: * https://codereview.chromium.org/619133002/ * https://codereview.chromium.org/627493002/ * https://codereview.chromium.org/623093002/ BUG=419516 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292296

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2237 lines, -2 lines) Patch
M scripts/slave/bot_update.py View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.py View 2 chunks +6 lines, -1 line 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android_arm64__dbg_.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android_builder.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android_builder__dbg_.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android_builder_forced.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android_clang__dbg_.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android_gn.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android_gn__dbg_.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android_tests__jb_nexus7_2_.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android_tests__jb_nexus7_2__dbg_.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android_tests__kk_nexus5_.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android_tests__kk_nexus5__dbg_.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android_tests__kk_nexus5__failing_test.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android_tests__kk_nexus5__forced.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_android_tests__kk_nexus5__forced_invalid.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux64_debug__parallel_.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_fyi_linux_msan.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_ios_debug.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_ios_release.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_debug.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux32_release.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug__gn_.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug_failing_test.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_debug_forced.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release__gn_.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux64_release__large_tests_.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_asan.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_memcheck.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_linux_tsan_v2.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac32_debug.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac32_release.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac32_release__large_tests_.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_debug.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac64_release.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_mac_asan.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_debug.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win32_release__large_tests_.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_debug.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win64_release.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win_drmemory_full.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win_drmemory_light.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/client_webrtc_win_syzyasan.json View 1 chunk +29 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android.json View 1 chunk +33 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_arm64.json View 1 chunk +33 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_clang.json View 1 chunk +33 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_gn.json View 1 chunk +33 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_gn_rel.json View 1 chunk +33 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_android_rel.json View 1 chunk +33 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_ios.json View 1 chunk +33 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_ios_rel.json View 1 chunk +33 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux.json View 1 chunk +33 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_asan.json View 1 chunk +33 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_baremetal.json View 1 chunk +33 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_gn.json View 1 chunk +33 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_gn_rel.json View 1 chunk +33 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_legacy_svn_patch.json View 1 chunk +31 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_memcheck.json View 1 chunk +33 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_rel.json View 1 chunk +33 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_linux_tsan2.json View 1 chunk +33 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac.json View 1 chunk +33 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_asan.json View 1 chunk +33 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_baremetal.json View 1 chunk +33 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_rel.json View 1 chunk +33 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_mac_x64_rel.json View 1 chunk +33 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win.json View 1 chunk +33 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_asan.json View 1 chunk +33 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_baremetal.json View 1 chunk +33 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_drmemory_full.json View 1 chunk +33 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_drmemory_light.json View 1 chunk +33 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_rel.json View 1 chunk +33 lines, -0 lines 0 comments Download
M scripts/slave/recipes/webrtc/standalone.expected/tryserver_webrtc_win_x64_rel.json View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
kjellander_chromium
6 years, 2 months ago (2014-10-03 09:14:21 UTC) #2
Paweł Hajdan Jr.
LGTM
6 years, 2 months ago (2014-10-03 10:06:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/628523002/1
6 years, 2 months ago (2014-10-03 11:11:31 UTC) #5
commit-bot: I haz the power
Presubmit check for 628523002-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 2 months ago (2014-10-03 11:12:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/628523002/1
6 years, 2 months ago (2014-10-03 11:38:38 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-03 11:40:39 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 292296

Powered by Google App Engine
This is Rietveld 408576698