Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 628333003: Remove implicit conversions from scoped_refptr to T* in content/ (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
no sievers, sky
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org, nona+watch_chromium.org, penghuang+watch_chromium.org, piman+watch_chromium.org, James Su, yukishiino+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove implicit conversions from scoped_refptr to T* in content/ This patch was generated by running the rewrite_scoped_refptr clang tool on an Android build. BUG=110610 Committed: https://crrev.com/165763c20c375201e93c5663f6b1fc0834503747 Cr-Commit-Position: refs/heads/master@{#298364}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -38 lines) Patch
M content/browser/android/in_process/synchronous_compositor_factory_impl.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_output_surface.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/android/java/gin_java_bridge_dispatcher_host.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/android/overscroll_glow.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/android/surface_texture_peer_browser_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/power_save_blocker_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/image_transport_factory_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M content/browser/web_contents/web_contents_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/gpu/stream_texture_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
dcheng
+sky for the power_save_blocker_android.cc change +sievers for everything else.
6 years, 2 months ago (2014-10-06 22:42:23 UTC) #2
no sievers
lgtm
6 years, 2 months ago (2014-10-06 22:47:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/628333003/1
6 years, 2 months ago (2014-10-06 23:10:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/15839)
6 years, 2 months ago (2014-10-06 23:48:47 UTC) #7
sky
LGTM
6 years, 2 months ago (2014-10-06 23:53:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/628333003/1
6 years, 2 months ago (2014-10-07 04:09:15 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as 5b4d94f82d7281719f235788b52a12186acd19e1
6 years, 2 months ago (2014-10-07 04:15:03 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 04:16:11 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/165763c20c375201e93c5663f6b1fc0834503747
Cr-Commit-Position: refs/heads/master@{#298364}

Powered by Google App Engine
This is Rietveld 408576698