content/browser/android/java/gin_java_bridge_dispatcher_host.cc - Issue 628333003: Remove implicit conversions from scoped_refptr to T* in content/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/java/gin_java_bridge_dispatcher_host.cc

Issue 628333003: Remove implicit conversions from scoped_refptr to T* in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/android/in_process/synchronous_compositor_output_surface.cc ('k') | content/browser/android/overscroll_glow.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/java/gin_java_bridge_dispatcher_host.cc

diff --git a/content/browser/android/java/gin_java_bridge_dispatcher_host.cc b/content/browser/android/java/gin_java_bridge_dispatcher_host.cc

index 29341a9380e4d58d669976a78d13b87254735f01..d324b3a9aefd846dfbca72fc8a1e6ebe158692ab 100644

--- a/content/browser/android/java/gin_java_bridge_dispatcher_host.cc

+++ b/content/browser/android/java/gin_java_bridge_dispatcher_host.cc

@@ -374,7 +374,7 @@ void GinJavaBridgeDispatcherHost::OnGetMethods(

return;

}

scoped_refptr<GinJavaBoundObject> object(*objects_.Lookup(object_id));

- if (!object) {

+ if (!object.get()) {

LOG(ERROR) << "WebView: Unknown object: " << object_id;

IPC::WriteParam(reply_msg, std::set<std::string>());

render_frame_host->Send(reply_msg);

@@ -410,7 +410,7 @@ void GinJavaBridgeDispatcherHost::OnHasMethod(

DCHECK_CURRENTLY_ON(BrowserThread::UI);

DCHECK(render_frame_host);

scoped_refptr<GinJavaBoundObject> object(*objects_.Lookup(object_id));

- if (!object) {

+ if (!object.get()) {

LOG(ERROR) << "WebView: Unknown object: " << object_id;

IPC::WriteParam(reply_msg, false);

render_frame_host->Send(reply_msg);

@@ -447,7 +447,7 @@ void GinJavaBridgeDispatcherHost::OnInvokeMethod(

DCHECK_CURRENTLY_ON(BrowserThread::UI);

DCHECK(render_frame_host);

scoped_refptr<GinJavaBoundObject> object(*objects_.Lookup(object_id));

- if (!object) {

+ if (!object.get()) {

LOG(ERROR) << "WebView: Unknown object: " << object_id;

base::ListValue result;

result.Append(base::Value::CreateNullValue());