Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1051)

Issue 628293002: Plumb OptDrawState down to VertexShaderBuilder (Closed)

Created:
6 years, 2 months ago by egdaniel
Modified:
6 years, 2 months ago
Reviewers:
joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Plumb OptDrawState down to VertexShaderBuilder BUG=skia: Committed: https://skia.googlesource.com/skia/+/307796bc2e3731099d96773db7385fe70cb94f7d

Patch Set 1 #

Patch Set 2 : Clean up #

Total comments: 1

Patch Set 3 : Make ODS a member of ProgramBuilder #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -22 lines) Patch
M src/gpu/gl/GrGLProgram.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 1 2 3 3 chunks +6 lines, -4 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentOnlyProgramBuilder.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLFragmentOnlyProgramBuilder.cpp View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLFullProgramBuilder.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLFullProgramBuilder.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp View 1 2 1 chunk +3 lines, -8 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
egdaniel
plumb ODS down to vertex shader builder
6 years, 2 months ago (2014-10-06 17:46:34 UTC) #2
joshua.litt
https://codereview.chromium.org/628293002/diff/20001/src/gpu/gl/GrGLProgram.cpp File src/gpu/gl/GrGLProgram.cpp (right): https://codereview.chromium.org/628293002/diff/20001/src/gpu/gl/GrGLProgram.cpp#newcode42 src/gpu/gl/GrGLProgram.cpp:42: if (builder->genProgram(optState, geometryProcessor, colorStages, coverageStages)) { I think optstate ...
6 years, 2 months ago (2014-10-06 18:04:56 UTC) #3
egdaniel
Made ODS a member of GrGLProgramBuilder
6 years, 2 months ago (2014-10-06 18:38:26 UTC) #5
joshua.litt
On 2014/10/06 18:38:26, egdaniel wrote: > Made ODS a member of GrGLProgramBuilder lgtm
6 years, 2 months ago (2014-10-06 18:47:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/628293002/80001
6 years, 2 months ago (2014-10-06 19:05:36 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-06 19:14:22 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:80001) as 307796bc2e3731099d96773db7385fe70cb94f7d

Powered by Google App Engine
This is Rietveld 408576698