Issue 628273003: Clean up ifdef around FilePath creation in src/components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 628273003: Clean up ifdef around FilePath creation in src/components (Closed)

Created:
6 years, 2 months ago by anujsharma

Modified:
6 years, 2 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, MRV

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Clean up ifdef around FilePath creation in src/components BUG=102853 Committed: https://crrev.com/ba0bc8f5eb6dbb2cfa2f76251b9c02ab64a4ae75 Cr-Commit-Position: refs/heads/master@{#298463}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -5 lines)			Patch
	M	components/feedback/feedback_data.cc	View		1 chunk	+2 lines, -5 lines	0 comments	Download

Total messages: 8 (2 generated)

anujsharma

On 2014/10/07 12:14:35, jochen wrote: > lgtm Thanks jochen for lgtm.

6 years, 2 months ago (2014-10-07 12:16:11 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/628273003/1

6 years, 2 months ago (2014-10-07 12:17:50 UTC) #6

commit-bot: I haz the power

Committed patchset #1 (id:1) as 6089f16af62cbc5a23e790e61deff85c42a7a95f

6 years, 2 months ago (2014-10-07 13:26:52 UTC) #7

commit-bot: I haz the power

6 years, 2 months ago (2014-10-07 13:27:28 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/ba0bc8f5eb6dbb2cfa2f76251b9c02ab64a4ae75
Cr-Commit-Position: refs/heads/master@{#298463}