Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Unified Diff: components/feedback/feedback_data.cc

Issue 628273003: Clean up ifdef around FilePath creation in src/components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/feedback/feedback_data.cc
diff --git a/components/feedback/feedback_data.cc b/components/feedback/feedback_data.cc
index 42e4b9f99ffb6f187df46679a27ae0ef2145fc55..3abe1cfc95472be3fe4808556df39454570c5871 100644
--- a/components/feedback/feedback_data.cc
+++ b/components/feedback/feedback_data.cc
@@ -92,11 +92,8 @@ void FeedbackData::AttachAndCompressFileData(
if (!attached_filedata.get() || attached_filedata->empty())
return;
++pending_op_count_;
-#if defined(OS_WIN)
- base::FilePath attached_file(base::UTF8ToWide(attached_filename_));
-#else
- base::FilePath attached_file(attached_filename_);
-#endif
+ base::FilePath attached_file =
+ base::FilePath::FromUTF8Unsafe(attached_filename_);
BrowserThread::PostBlockingPoolTaskAndReply(
FROM_HERE,
base::Bind(&FeedbackCommon::CompressFile,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698