Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(851)

Issue 628233002: replace OVERRIDE and FINAL with override and final in sandbox/ (Closed)

Created:
6 years, 2 months ago by Mostyn Bramley-Moore
Modified:
6 years, 2 months ago
CC:
chromium-reviews, mkwst+moarreviews-ipc_chromium.org, wfh+watch_chromium.org, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

replace OVERRIDE and FINAL with override and final in sandbox/ R=cpu@chromium.org,dcheng@chromium.org BUG=417463 Committed: https://crrev.com/db8e2c698d1e5d7da161093f9521f2ab9bdf5ead Cr-Commit-Position: refs/heads/master@{#298401}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -127 lines) Patch
M sandbox/linux/bpf_dsl/bpf_dsl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M sandbox/linux/bpf_dsl/bpf_dsl.cc View 12 chunks +12 lines, -12 lines 0 comments Download
M sandbox/linux/bpf_dsl/bpf_dsl_more_unittest.cc View 26 chunks +26 lines, -26 lines 0 comments Download
M sandbox/linux/bpf_dsl/bpf_dsl_unittest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/baseline_policy.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sandbox/linux/seccomp-bpf-helpers/syscall_parameters_restrictions_unittests.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M sandbox/linux/seccomp-bpf/bpf_tester_compatibility_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sandbox/linux/seccomp-bpf/bpf_tests.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sandbox/linux/seccomp-bpf/bpf_tests_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M sandbox/linux/seccomp-bpf/sandbox_bpf.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M sandbox/linux/seccomp-bpf/sandbox_bpf_test_runner.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sandbox/linux/seccomp-bpf/syscall_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/linux/tests/sandbox_test_runner_function_pointer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sandbox/mac/bootstrap_sandbox_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/mac/dispatch_source_mach_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/mac/launchd_interception_server.h View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/mac/mach_message_server.h View 1 chunk +7 lines, -7 lines 0 comments Download
M sandbox/mac/xpc_message_server.h View 1 chunk +7 lines, -7 lines 0 comments Download
M sandbox/mac/xpc_message_server_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sandbox/win/src/broker_services.h View 2 chunks +8 lines, -8 lines 0 comments Download
M sandbox/win/src/sandbox_policy_base.h View 1 chunk +27 lines, -27 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Mostyn Bramley-Moore
@cpu: can you give this a thumbs-up? The script I used to make this change ...
6 years, 2 months ago (2014-10-06 14:32:00 UTC) #1
jln (very slow on Chromium)
lgtm
6 years, 2 months ago (2014-10-06 19:30:27 UTC) #2
cpu_(ooo_6.6-7.5)
lgtm on sandbox/win
6 years, 2 months ago (2014-10-06 19:35:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/628233002/1
6 years, 2 months ago (2014-10-06 19:48:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/59920)
6 years, 2 months ago (2014-10-06 23:26:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/628233002/1
6 years, 2 months ago (2014-10-07 06:11:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as aa1999d4e5c643cc684eb715f4827af02bf199d1
6 years, 2 months ago (2014-10-07 06:12:27 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 06:13:08 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db8e2c698d1e5d7da161093f9521f2ab9bdf5ead
Cr-Commit-Position: refs/heads/master@{#298401}

Powered by Google App Engine
This is Rietveld 408576698