Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Issue 628133004: Revert of Implement :valid and :invalid pseudoclass for <form> (Closed)

Created:
6 years, 2 months ago by Bartek Nowierski
Modified:
6 years, 2 months ago
Reviewers:
keishi, tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, blink-reviews-css, sof, eae+blinkwatch, ed+blinkwatch_opera.com, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, rwlbuis, mlamouri (slow - plz ping)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of Implement :valid and :invalid pseudoclass for <form> (patchset #8 id:140001 of https://codereview.chromium.org/616443002/) Reason for revert: https://code.google.com/p/chromium/issues/detail?id=420450 "Heap-use-after-free in blink::RenderBlock::willBeDestroyed" Original issue's description: > Implement :valid and :invalid pseudoclass for <form> > > BUG=360466 > TEST=added form-pseudo-valid-style.html layout test > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183185 TBR=keishi@chromium.org,tkent@chromium.org NOTREECHECKS=true NOTRY=true BUG=360466 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183292

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -172 lines) Patch
D LayoutTests/fast/forms/form-pseudo-valid-style.html View 1 chunk +0 lines, -80 lines 0 comments Download
D LayoutTests/fast/forms/form-pseudo-valid-style-expected.txt View 1 chunk +0 lines, -32 lines 0 comments Download
M Source/core/css/SelectorChecker.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/SharedStyleFinder.cpp View 2 chunks +1 line, -6 lines 0 comments Download
M Source/core/dom/Element.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormControlElement.h View 3 chunks +1 line, -7 lines 0 comments Download
M Source/core/html/HTMLFormControlElement.cpp View 4 chunks +2 lines, -22 lines 0 comments Download
M Source/core/html/HTMLFormElement.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 2 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Bartek Nowierski
Created Revert of Implement :valid and :invalid pseudoclass for <form>
6 years, 2 months ago (2014-10-07 00:18:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/628133004/1
6 years, 2 months ago (2014-10-07 00:20:04 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 2 months ago (2014-10-07 00:20:06 UTC) #4
keishi
lgtm
6 years, 2 months ago (2014-10-07 00:29:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/628133004/1
6 years, 2 months ago (2014-10-07 00:30:51 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 00:32:14 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183292

Powered by Google App Engine
This is Rietveld 408576698