Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Unified Diff: Source/core/html/HTMLFormControlElement.cpp

Issue 628133004: Revert of Implement :valid and :invalid pseudoclass for <form> (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLFormControlElement.h ('k') | Source/core/html/HTMLFormElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLFormControlElement.cpp
diff --git a/Source/core/html/HTMLFormControlElement.cpp b/Source/core/html/HTMLFormControlElement.cpp
index 32dae58adfbb32421f714d24f1650b8738c5cad1..6029f3fe1e814339a8d896db5eb0e1bf69de265b 100644
--- a/Source/core/html/HTMLFormControlElement.cpp
+++ b/Source/core/html/HTMLFormControlElement.cpp
@@ -266,25 +266,6 @@
FormAssociatedElement::removedFrom(insertionPoint);
}
-void HTMLFormControlElement::willChangeForm()
-{
- formOwnerSetNeedsValidityCheck();
- FormAssociatedElement::willChangeForm();
-}
-
-void HTMLFormControlElement::didChangeForm()
-{
- formOwnerSetNeedsValidityCheck();
- FormAssociatedElement::didChangeForm();
-}
-
-void HTMLFormControlElement::formOwnerSetNeedsValidityCheck()
-{
- HTMLFormElement* form = formOwner();
- if (form)
- form->setNeedsValidityCheck();
-}
-
void HTMLFormControlElement::setChangedSinceLastFormControlChangeEvent(bool changed)
{
m_wasChangedSinceLastFormControlChangeEvent = changed;
@@ -488,7 +469,7 @@
bool HTMLFormControlElement::checkValidity(WillBeHeapVector<RefPtrWillBeMember<FormAssociatedElement> >* unhandledInvalidControls)
{
- if (!willValidate() || isValidElement())
+ if (!willValidate() || isValidFormControlElement())
return true;
// An event handler can deref this object.
RefPtrWillBeRawPtr<HTMLFormControlElement> protector(this);
@@ -499,7 +480,7 @@
return false;
}
-bool HTMLFormControlElement::isValidElement()
+bool HTMLFormControlElement::isValidFormControlElement()
{
// If the following assertion fails, setNeedsValidityCheck() is not called
// correctly when something which changes validity is updated.
@@ -511,7 +492,6 @@
{
bool newIsValid = valid();
if (willValidate() && newIsValid != m_isValid) {
- formOwnerSetNeedsValidityCheck();
// Update style for pseudo classes such as :valid :invalid.
setNeedsStyleRecalc(SubtreeStyleChange, StyleChangeReasonForTracing::createWithExtraData(StyleChangeReason::PseudoClass, StyleChangeExtraData::Invalid));
}
« no previous file with comments | « Source/core/html/HTMLFormControlElement.h ('k') | Source/core/html/HTMLFormElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698