Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 628123002: Replacing the OVERRIDE with override and FINAL with final in jingle (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replacing the OVERRIDE with override and FINAL with final in jingle This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://crrev.com/239c9f3ca43aa341b8362c7c622c78e2347d2d60 Cr-Commit-Position: refs/heads/master@{#298335}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -176 lines) Patch
M jingle/glue/channel_socket_adapter.h View 1 chunk +4 lines, -4 lines 0 comments Download
M jingle/glue/chrome_async_socket.h View 5 chunks +8 lines, -8 lines 0 comments Download
M jingle/glue/chrome_async_socket_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M jingle/glue/fake_ssl_client_socket.h View 1 chunk +18 lines, -18 lines 0 comments Download
M jingle/glue/proxy_resolving_client_socket.h View 1 chunk +18 lines, -18 lines 0 comments Download
M jingle/glue/pseudotcp_adapter.h View 1 chunk +18 lines, -18 lines 0 comments Download
M jingle/glue/pseudotcp_adapter.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M jingle/glue/pseudotcp_adapter_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M jingle/glue/task_pump.h View 1 chunk +2 lines, -2 lines 0 comments Download
M jingle/glue/thread_wrapper.h View 1 chunk +16 lines, -16 lines 0 comments Download
M jingle/glue/thread_wrapper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/glue/xmpp_client_socket_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M jingle/notifier/base/fake_base_task.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/base/gaia_token_pre_xmpp_auth.h View 1 chunk +10 lines, -10 lines 0 comments Download
M jingle/notifier/base/gaia_token_pre_xmpp_auth.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/base/weak_xmpp_client.h View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/communicator/login.h View 1 chunk +7 lines, -7 lines 0 comments Download
M jingle/notifier/communicator/single_login_attempt.h View 1 chunk +2 lines, -2 lines 0 comments Download
M jingle/notifier/communicator/single_login_attempt_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M jingle/notifier/listener/fake_push_client.h View 1 chunk +6 lines, -6 lines 0 comments Download
M jingle/notifier/listener/fake_push_client_observer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M jingle/notifier/listener/non_blocking_push_client.h View 1 chunk +6 lines, -6 lines 0 comments Download
M jingle/notifier/listener/non_blocking_push_client.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M jingle/notifier/listener/non_blocking_push_client_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M jingle/notifier/listener/push_notifications_listen_task.h View 1 chunk +3 lines, -3 lines 0 comments Download
M jingle/notifier/listener/push_notifications_send_update_task.h View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/listener/push_notifications_subscribe_task.h View 1 chunk +3 lines, -3 lines 0 comments Download
M jingle/notifier/listener/send_ping_task.h View 1 chunk +3 lines, -3 lines 0 comments Download
M jingle/notifier/listener/xmpp_push_client.h View 1 chunk +13 lines, -13 lines 0 comments Download
M jingle/notifier/listener/xmpp_push_client_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-06 11:11:43 UTC) #2
MRV
On 2014/10/06 11:11:43, MRV wrote: > PTAL Dear Mr. Sergey Ulanov PTAL
6 years, 2 months ago (2014-10-06 16:16:37 UTC) #3
Mostyn Bramley-Moore
Here's my corresponding patch- let's compare the diffs... https://codereview.chromium.org/628243002/
6 years, 2 months ago (2014-10-06 16:18:24 UTC) #4
Mostyn Bramley-Moore
On 2014/10/06 16:18:24, Mostyn Bramley-Moore wrote: > Here's my corresponding patch- let's compare the diffs... ...
6 years, 2 months ago (2014-10-06 16:19:57 UTC) #5
Sergey Ulanov
lgtm
6 years, 2 months ago (2014-10-06 18:08:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/628123002/1
6 years, 2 months ago (2014-10-06 18:10:21 UTC) #8
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 2 months ago (2014-10-07 01:28:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/628123002/1
6 years, 2 months ago (2014-10-07 02:00:09 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8270f8a3e17e2926892b274db9fd8c23560078cd
6 years, 2 months ago (2014-10-07 02:35:32 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 02:36:28 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/239c9f3ca43aa341b8362c7c622c78e2347d2d60
Cr-Commit-Position: refs/heads/master@{#298335}

Powered by Google App Engine
This is Rietveld 408576698