Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 627773002: Move painting code from SVGInlineTextBox to SVGInlineTextBoxPainter. (Closed)

Created:
6 years, 2 months ago by chrishtr
Modified:
6 years, 2 months ago
Reviewers:
pdr., fs
CC:
blink-reviews, blink-reviews-rendering, krit, eae+blinkwatch, ed+blinkwatch_opera.com, f(malita), fs, gyuyoung.kim_webkit.org, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, rune+blink, Stephen Chennney, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Move painting code from SVGInlineTextBox to SVGInlineTextBoxPainter. BUG=412088 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183298

Patch Set 1 #

Patch Set 2 : Fixed. #

Patch Set 3 : Fixed #

Patch Set 4 : Fixed. #

Total comments: 2

Patch Set 5 : Merged. #

Patch Set 6 : Fix debug build. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -843 lines) Patch
M Source/core/core.gypi View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/paint/InlineTextBoxPainter.cpp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A Source/core/paint/SVGInlineTextBoxPainter.h View 1 2 1 chunk +43 lines, -0 lines 0 comments Download
A + Source/core/paint/SVGInlineTextBoxPainter.cpp View 1 2 3 4 5 16 chunks +91 lines, -365 lines 0 comments Download
M Source/core/rendering/InlineTextBox.cpp View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/SVGInlineFlowBox.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/rendering/svg/SVGInlineTextBox.h View 2 chunks +2 lines, -12 lines 0 comments Download
M Source/core/rendering/svg/SVGInlineTextBox.cpp View 1 2 3 4 3 chunks +4 lines, -463 lines 0 comments Download
M Source/core/rendering/svg/SVGRootInlineBox.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
chrishtr
6 years, 2 months ago (2014-10-03 19:08:07 UTC) #2
pdr.
LGTM, rs=me. There are compile failures, I think you are just missing a forward declaration.
6 years, 2 months ago (2014-10-03 21:44:16 UTC) #3
fs
On 2014/10/03 21:44:16, pdr wrote: > LGTM, rs=me. There are compile failures, I think you ...
6 years, 2 months ago (2014-10-06 08:34:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/627773002/100001
6 years, 2 months ago (2014-10-06 23:15:41 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 02:08:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as 183298

Powered by Google App Engine
This is Rietveld 408576698