Issue 62753005: Refactor pkg/path.

Issue 62753005: Refactor pkg/path. (Closed)

Created:
7 years, 1 month ago by nweiz

Modified:
7 years, 1 month ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Refactor pkg/path. This CL does several things: * Splits lib/path.dart into multiple libraries. * Renames "Builder" to "Context". * Makes the Context API match the top-level functions ("root" was renamed to "current" and "resolve" was renamed to "absolute"). * The top-level "absolute" function now takes multiple parts, to match [Context.absolute]. R=rnystrom@google.com BUG=14981 Committed: https://code.google.com/p/dart/source/detail?r=30423

Patch Set 1 #

Patch Set 2 : remove dummy file #

Total comments: 5

Patch Set 3 : code review #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2141 lines, -2094 lines)			Patch
M	pkg/path/README.md	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	pkg/path/lib/path.dart	View	1 2	16 chunks	+49 lines, -939 lines	0 comments	Download
A	pkg/path/lib/src/context.dart	View	1 2	1 chunk	+492 lines, -0 lines	0 comments	Download
A	pkg/path/lib/src/parsed_path.dart	View		1 chunk	+186 lines, -0 lines	0 comments	Download
A	pkg/path/lib/src/path_exception.dart	View		1 chunk	+15 lines, -0 lines	0 comments	Download
A	pkg/path/lib/src/style.dart	View		1 chunk	+118 lines, -0 lines	0 comments	Download
A	pkg/path/lib/src/style/posix.dart	View		1 chunk	+42 lines, -0 lines	0 comments	Download
A	pkg/path/lib/src/style/url.dart	View		1 chunk	+25 lines, -0 lines	0 comments	Download
A	pkg/path/lib/src/style/windows.dart	View		1 chunk	+74 lines, -0 lines	0 comments	Download
M	pkg/path/test/browser_test.dart	View		1 chunk	+7 lines, -7 lines	0 comments	Download
M	pkg/path/test/io_test.dart	View		1 chunk	+7 lines, -7 lines	0 comments	Download
M	pkg/path/test/path_test.dart	View		1 chunk	+12 lines, -12 lines	0 comments	Download
M	pkg/path/test/posix_test.dart	View		4 chunks	+302 lines, -306 lines	0 comments	Download
M	pkg/path/test/relative_test.dart	View		3 chunks	+15 lines, -15 lines	0 comments	Download
M	pkg/path/test/url_test.dart	View		5 chunks	+406 lines, -406 lines	0 comments	Download
M	pkg/path/test/windows_test.dart	View		5 chunks	+382 lines, -388 lines	0 comments	Download
M	pkg/scheduled_test/lib/src/descriptor/directory_descriptor.dart	View		3 chunks	+3 lines, -6 lines	0 comments	Download
M	pkg/stack_trace/test/vm_test.dart	View		1 chunk	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

Couple of nits, but LGTM! After this goes in, what do you think about publishing ...

7 years, 1 month ago (2013-11-18 20:43:21 UTC) #2

nweiz

https://codereview.chromium.org/62753005/diff/40001/pkg/path/lib/path.dart File pkg/path/lib/path.dart (right): https://codereview.chromium.org/62753005/diff/40001/pkg/path/lib/path.dart#newcode117 pkg/path/lib/path.dart:117: /// context.basename('path/to/'); // -> 'to' On 2013/11/18 20:43:21, Bob ...

7 years, 1 month ago (2013-11-19 20:44:53 UTC) #3

nweiz

7 years, 1 month ago (2013-11-19 20:48:55 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r30423 (presubmit successful).

Expand Messages | Collapse Messages