Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: pkg/scheduled_test/lib/src/descriptor/directory_descriptor.dart

Issue 62753005: Refactor pkg/path. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: code review Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/path/test/windows_test.dart ('k') | pkg/stack_trace/test/vm_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/scheduled_test/lib/src/descriptor/directory_descriptor.dart
diff --git a/pkg/scheduled_test/lib/src/descriptor/directory_descriptor.dart b/pkg/scheduled_test/lib/src/descriptor/directory_descriptor.dart
index e5baf445d57b649364d18ad9908be78fcb9b9129..1b377ae7f6e76e30065f065499906ed29eb706c9 100644
--- a/pkg/scheduled_test/lib/src/descriptor/directory_descriptor.dart
+++ b/pkg/scheduled_test/lib/src/descriptor/directory_descriptor.dart
@@ -13,9 +13,6 @@ import '../../descriptor.dart';
import '../../scheduled_test.dart';
import '../utils.dart';
-/// A path builder to ensure that [load] uses POSIX paths.
-final path.Builder _path = new path.Builder(style: path.Style.posix);
-
/// A descriptor describing a directory containing multiple files.
class DirectoryDescriptor extends Descriptor implements LoadableDescriptor {
/// The entries contained within this directory. This is intentionally
@@ -58,11 +55,11 @@ class DirectoryDescriptor extends Descriptor implements LoadableDescriptor {
Stream<List<int>> load(String pathToLoad) {
return futureStream(new Future.value().then((_) {
- if (_path.isAbsolute(pathToLoad)) {
+ if (path.posix.isAbsolute(pathToLoad)) {
throw new ArgumentError("Can't load absolute path '$pathToLoad'.");
}
- var split = _path.split(_path.normalize(pathToLoad));
+ var split = path.posix.split(path.posix.normalize(pathToLoad));
if (split.isEmpty || split.first == '.' || split.first == '..') {
throw new ArgumentError("Can't load '$pathToLoad' from within "
"'$name'.");
@@ -88,7 +85,7 @@ class DirectoryDescriptor extends Descriptor implements LoadableDescriptor {
return (matchingEntries.first as ReadableDescriptor).read();
} else {
return (matchingEntries.first as LoadableDescriptor)
- .load(_path.joinAll(remainingPath));
+ .load(path.posix.joinAll(remainingPath));
}
}
}));
« no previous file with comments | « pkg/path/test/windows_test.dart ('k') | pkg/stack_trace/test/vm_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698