Issue 627273003: Carry advances between runs in HarfBuzzShaper.cpp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 627273003: Carry advances between runs in HarfBuzzShaper.cpp (Closed)

Created:
6 years, 2 months ago by Dominik Röttsches

Modified:
6 years, 2 months ago

Reviewers:
leviw_travelin_and_unemployed, behdad, eae, jbroman

CC:
blink-reviews, jamesr, pdr+graphicswatchlist_chromium.org, jbroman, mkwst+moarreviews_chromium.org, danakj, Rik, Stephen Chennney, krit, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

Carry advances between runs in HarfBuzzShaper.cpp When the setDrawRange method is used to restrict painting to a range, the initial advance has to be carried over to the first glyph that's being added to the glyph buffer, otherwise things like selection painting will fail. Fixes a regression after refactoring GlyphBuffer in r182991. BUG=420614 R=eae,behdad,leviw Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183347

Patch Set 1 #

Patch Set 2 : Have Linux baseline be generated by the bot #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -13 lines)			Patch
M	LayoutTests/TestExpectations	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/text/selection-multiple-runs.html	View		1 chunk	+23 lines, -0 lines	0 comments	Download
M	Source/platform/fonts/harfbuzz/HarfBuzzShaper.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp	View		4 chunks	+19 lines, -12 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/627273003/20001

6 years, 2 months ago (2014-10-07 14:32:26 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-07 16:09:46 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as 183347

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages