Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 627273003: Carry advances between runs in HarfBuzzShaper.cpp (Closed)

Created:
5 years, 9 months ago by Dominik Röttsches
Modified:
5 years, 9 months ago
CC:
blink-reviews, jamesr, pdr+graphicswatchlist_chromium.org, jbroman, mkwst+moarreviews_chromium.org, danakj, Rik, Stephen Chennney, krit, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Carry advances between runs in HarfBuzzShaper.cpp When the setDrawRange method is used to restrict painting to a range, the initial advance has to be carried over to the first glyph that's being added to the glyph buffer, otherwise things like selection painting will fail. Fixes a regression after refactoring GlyphBuffer in r182991. BUG=420614 R=eae,behdad,leviw Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183347

Patch Set 1 #

Patch Set 2 : Have Linux baseline be generated by the bot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -13 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/text/selection-multiple-runs.html View 1 chunk +23 lines, -0 lines 0 comments Download
M Source/platform/fonts/harfbuzz/HarfBuzzShaper.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp View 4 chunks +19 lines, -12 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Dominik Röttsches
5 years, 9 months ago (2014-10-07 10:38:50 UTC) #2
eae
LGTM Thanks Dominik!
5 years, 9 months ago (2014-10-07 14:32:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/627273003/20001
5 years, 9 months ago (2014-10-07 14:32:26 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2014-10-07 16:09:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 183347

Powered by Google App Engine
This is Rietveld 408576698