Source/platform/fonts/harfbuzz/HarfBuzzShaper.h - Issue 627273003: Carry advances between runs in HarfBuzzShaper.cpp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/harfbuzz/HarfBuzzShaper.h

Issue 627273003: Carry advances between runs in HarfBuzzShaper.cpp (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Have Linux baseline be generated by the bot Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/fonts/harfbuzz/HarfBuzzShaper.h

diff --git a/Source/platform/fonts/harfbuzz/HarfBuzzShaper.h b/Source/platform/fonts/harfbuzz/HarfBuzzShaper.h

index 3672df01dd2a65b9b32917a23ee317027b67c969..8d6425e518e21ce55b1a16a3b6b7c4c2c57381d8 100644

--- a/Source/platform/fonts/harfbuzz/HarfBuzzShaper.h

+++ b/Source/platform/fonts/harfbuzz/HarfBuzzShaper.h

@@ -129,7 +129,7 @@ private:

bool createHarfBuzzRuns();

bool shapeHarfBuzzRuns();

bool fillGlyphBuffer(GlyphBuffer*);

- void fillGlyphBufferFromHarfBuzzRun(GlyphBufferWithOffsets*, HarfBuzzRun*);

+ void fillGlyphBufferFromHarfBuzzRun(GlyphBufferWithOffsets*, HarfBuzzRun*, float& carryAdvance);

void fillGlyphBufferForTextEmphasis(GlyphBuffer*, HarfBuzzRun* currentRun);

void setGlyphPositionsForHarfBuzzRun(HarfBuzzRun*, hb_buffer_t*);

void addHarfBuzzRun(unsigned startCharacter, unsigned endCharacter, const SimpleFontData*, UScriptCode);