Issue 626983002: Eliminate redundant IPC used for showing the Windows virtual keyboard

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 626983002: Eliminate redundant IPC used for showing the Windows virtual keyboard (Closed)

Created:
6 years, 2 months ago by jdduke (slow)

Modified:
6 years, 2 months ago

Reviewers:

CC:
chromium-reviews, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, mkwst+moarreviews-ipc_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Eliminate redundant IPC used for showing the Windows virtual keyboard Remove |ViewHostMsg_FocusedNodeTouched|, currently used to display the Windows virtual keyboard. Instead, add a separate parameter to the existing |ViewHostMsg_FocusedNodeChanged| indicating the causal event type, allowing that message to control showing/hiding of the keyboard. BUG=420130

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -38 lines)			Patch
M	content/browser/renderer_host/render_view_host_impl.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host_impl.cc	View	3 chunks	+11 lines, -14 lines	0 comments	Download
M	content/common/view_messages.h	View	2 chunks	+7 lines, -10 lines	0 comments	Download
M	content/renderer/render_view_browsertest.cc	View	3 chunks	+3 lines, -0 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View	2 chunks	+2 lines, -12 lines	0 comments	Download