content/renderer/render_view_browsertest.cc - Issue 626983002: Eliminate redundant IPC used for showing the Windows virtual keyboard

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_browsertest.cc

Issue 626983002: Eliminate redundant IPC used for showing the Windows virtual keyboard (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_view_browsertest.cc

diff --git a/content/renderer/render_view_browsertest.cc b/content/renderer/render_view_browsertest.cc

index bbf04546a2dff3ecea2251e0e51c8fb424d5b393..cdff1e2c143af1c0892376d66ef92442bb616a6a 100644

--- a/content/renderer/render_view_browsertest.cc

+++ b/content/renderer/render_view_browsertest.cc

@@ -2338,6 +2338,7 @@ TEST_F(RenderViewImplTest, FocusElementCallsFocusedNodeChanged) {

ViewHostMsg_FocusedNodeChanged::Param params;

ViewHostMsg_FocusedNodeChanged::Read(msg1, &params);

EXPECT_TRUE(params.a);

+ EXPECT_EQ(blink::WebInputEvent:Undefined, params.b);

render_thread_->sink().ClearMessages();

ExecuteJavaScript("document.getElementById('test2').focus();");

@@ -2346,6 +2347,7 @@ TEST_F(RenderViewImplTest, FocusElementCallsFocusedNodeChanged) {

EXPECT_TRUE(msg2);

ViewHostMsg_FocusedNodeChanged::Read(msg2, &params);

EXPECT_TRUE(params.a);

+ EXPECT_EQ(blink::WebInputEvent:Undefined, params.b);

render_thread_->sink().ClearMessages();

view()->webview()->clearFocusedElement();

@@ -2354,6 +2356,7 @@ TEST_F(RenderViewImplTest, FocusElementCallsFocusedNodeChanged) {

EXPECT_TRUE(msg3);

ViewHostMsg_FocusedNodeChanged::Read(msg3, &params);

EXPECT_FALSE(params.a);

+ EXPECT_EQ(blink::WebInputEvent:Undefined, params.b);

render_thread_->sink().ClearMessages();

}

« no previous file with comments | « content/common/view_messages.h ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »