Use early expansion for debug_optimize and release_optimize

build/common.gypi

Index: build/common.gypi
===================================================================
--- build/common.gypi	(revision 71659)
+++ build/common.gypi	(working copy)
@@ -951,7 +951,7 @@
               '_DEBUG',
             ],
             'cflags': [
-              '-O>(debug_optimize)',
+              '-O<(debug_optimize)',

[Mark Mentovai, 2011/01/24 19:14:09]

The point of late expansion is that individual targets ought to be able to
override this as needed. In practice, this is rarely needed, and if I see it
being done anywhere, chances are I’ll give the person who wrote it a hard time
until I’m satisfied that it’s absolutely necessary. The media team (and Albert
and Frank) convinced me that it was necessary in the one spot I’m aware of where
it’s actually used.

Your proposed change is incorrect, but I understand that your needs may be
different. I see that you’ve already hunted down the original review for this
line. As I recall, some media code needed to ensure that a specific value would
be used here or the generated code would be really bad and really slow, and I’m
sure matters would be even worse under Valgrind. If you’re willing to tolerate
that sort of badness and slowness, I’m sure we can cook up a way to force this
to use a different value in Valgrind-land.

               '-g',
             ],
           },
@@ -967,7 +967,7 @@
               'no_gc_sections%': 0,
             },
             'cflags': [
-              '-O>(release_optimize)',
+              '-O<(release_optimize)',
               # Don't emit the GCC version ident directives, they just end up
               # in the .comment section taking up binary size.
               '-fno-ident',