Use early expansion for debug_optimize and release_optimize

build/common.gypi

 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # IMPORTANT:
 # Please don't directly include this file if you are building via gyp_chromium,
 # since gyp_chromium is automatically forcing its inclusion.
 {
   # Variables expected to be overriden on the GYP command line (-D) or by
   # ~/.gyp/include.gypi.
@@ skipping 933 matching lines @@
         ],
         'configurations': {
           'Debug_Base': {
             'variables': {
               'debug_optimize%': '0',
             },
             'defines': [
               '_DEBUG',
             ],
             'cflags': [
-              '-O>(debug_optimize)',
+              '-O<(debug_optimize)',

[Mark Mentovai, 2011/01/24 19:14:09]

The point of late expansion is that individual targets ought to be able to
override this as needed. In practice, this is rarely needed, and if I see it
being done anywhere, chances are I’ll give the person who wrote it a hard time
until I’m satisfied that it’s absolutely necessary. The media team (and Albert
and Frank) convinced me that it was necessary in the one spot I’m aware of where
it’s actually used.

Your proposed change is incorrect, but I understand that your needs may be
different. I see that you’ve already hunted down the original review for this
line. As I recall, some media code needed to ensure that a specific value would
be used here or the generated code would be really bad and really slow, and I’m
sure matters would be even worse under Valgrind. If you’re willing to tolerate
that sort of badness and slowness, I’m sure we can cook up a way to force this
to use a different value in Valgrind-land.

               '-g',
             ],
           },
           'Release_Base': {
             'variables': {
               'release_optimize%': '2',
               # Binaries become big and gold is unable to perform GC
               # and remove unused sections for some of test targets
               # on 32 bit platform.
               # (This is currently observed only in chromeos valgrind bots)
               # The following flag is to disable --gc-sections linker
               # option for these bots.
               'no_gc_sections%': 0,
             },
             'cflags': [
-              '-O>(release_optimize)',
+              '-O<(release_optimize)',
               # Don't emit the GCC version ident directives, they just end up
               # in the .comment section taking up binary size.
               '-fno-ident',
               # Put data and code in their own sections, so that unused symbols
               # can be removed at link time with --gc-sections.
               '-fdata-sections',
               '-ffunction-sections',
             ],
             'ldflags': [
               # Specifically tell the linker to perform optimizations.
@@ skipping 523 matching lines @@
     # and therefore SYMROOT, needs to be set at the project level.
     'SYMROOT': '<(DEPTH)/xcodebuild',
   },
 }
 
 # Local Variables:
 # tab-width:2
 # indent-tabs-mode:nil
 # End:
 # vim: set expandtab tabstop=2 shiftwidth=2: