Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 626693003: Clean up forward declarations and include files in Source/bindings (Closed)

Created:
6 years, 2 months ago by zhaoze.zhou
Modified:
6 years, 2 months ago
Reviewers:
haraken, yurys, rwlbuis
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Clean up forward declarations and include files in Source/bindings These forward references and include files not needed anymore. After this patch, Source/bindings has no unneeded forward references and include files any more. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183225

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -57 lines) Patch
M Source/bindings/core/v8/BindingSecurity.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/CustomElementConstructorBuilder.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/DOMWrapperWorld.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/ModuleProxy.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/PageScriptDebugServer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/ScriptController.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/ScriptDebugServer.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/bindings/core/v8/ScriptPreprocessor.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/ScriptProfiler.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/bindings/core/v8/ScriptPromise.h View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/bindings/core/v8/V8Binding.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/core/v8/V8ErrorHandler.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/core/v8/V8EventListener.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/core/v8/V8EventListenerList.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/V8LazyEventListener.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/V8PerIsolateData.h View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/V8StringResource.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/WindowProxy.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/WorkerScriptDebugServer.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/core/v8/WrapperTypeInfo.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
zhaoze.zhou
6 years, 2 months ago (2014-10-03 23:40:00 UTC) #2
rwlbuis
Looks great! Added reviewers...
6 years, 2 months ago (2014-10-04 00:17:32 UTC) #4
haraken
LGTM
6 years, 2 months ago (2014-10-04 00:27:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/626693003/1
6 years, 2 months ago (2014-10-04 01:28:35 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-04 01:32:50 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 183225

Powered by Google App Engine
This is Rietveld 408576698