Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Side by Side Diff: Source/bindings/core/v8/ScriptPromise.h

Issue 626693003: Clean up forward declarations and include files in Source/bindings (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/core/v8/ScriptProfiler.h ('k') | Source/bindings/core/v8/V8Binding.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 15 matching lines...) Expand all
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef ScriptPromise_h 31 #ifndef ScriptPromise_h
32 #define ScriptPromise_h 32 #define ScriptPromise_h
33 33
34 #include "bindings/core/v8/ScriptFunction.h" 34 #include "bindings/core/v8/ScriptFunction.h"
35 #include "bindings/core/v8/ScriptValue.h" 35 #include "bindings/core/v8/ScriptValue.h"
36 #include "bindings/core/v8/V8ThrowException.h"
37 #include "core/dom/ExceptionCode.h"
38 #include "platform/heap/Handle.h" 36 #include "platform/heap/Handle.h"
39 #include "wtf/PassOwnPtr.h"
40 #include "wtf/PassRefPtr.h" 37 #include "wtf/PassRefPtr.h"
41 #include "wtf/text/WTFString.h"
42 #include <v8.h> 38 #include <v8.h>
43 39
44 namespace blink { 40 namespace blink {
45 41
46 class DOMException; 42 class DOMException;
47 class ExceptionState;
48 43
49 // ScriptPromise is the class for representing Promise values in C++ world. 44 // ScriptPromise is the class for representing Promise values in C++ world.
50 // ScriptPromise holds a Promise. 45 // ScriptPromise holds a Promise.
51 // So holding a ScriptPromise as a member variable in DOM object causes 46 // So holding a ScriptPromise as a member variable in DOM object causes
52 // memory leaks since it has a reference from C++ to V8. 47 // memory leaks since it has a reference from C++ to V8.
53 // 48 //
54 class ScriptPromise FINAL { 49 class ScriptPromise FINAL {
55 public: 50 public:
56 // Constructs an empty promise. 51 // Constructs an empty promise.
57 ScriptPromise() { } 52 ScriptPromise() { }
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 133
139 private: 134 private:
140 RefPtr<ScriptState> m_scriptState; 135 RefPtr<ScriptState> m_scriptState;
141 ScriptValue m_promise; 136 ScriptValue m_promise;
142 }; 137 };
143 138
144 } // namespace blink 139 } // namespace blink
145 140
146 141
147 #endif // ScriptPromise_h 142 #endif // ScriptPromise_h
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/ScriptProfiler.h ('k') | Source/bindings/core/v8/V8Binding.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698