Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 626073002: Update identifier syntax to disallow U+2E2F (Closed)

Created:
6 years, 2 months ago by Diego Pino
Modified:
6 years, 2 months ago
CC:
v8-dev, aperez, vjaquez, gemont_igalia.com, Michael Starzinger, Erik Corry
Project:
v8
Visibility:
Public.

Description

Update identifier syntax to disallow U+2E2F BUG=v8:2892 LOG=

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fixed test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/char-predicates.h View 2 chunks +3 lines, -0 lines 0 comments Download
M test/mjsunit/var.js View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
Diego Pino
The solution seems a bit naive but there are already characters, that may not be ...
6 years, 2 months ago (2014-10-03 18:59:46 UTC) #2
mathias
https://codereview.chromium.org/626073002/diff/1/test/mjsunit/var.js File test/mjsunit/var.js (right): https://codereview.chromium.org/626073002/diff/1/test/mjsunit/var.js#newcode40 test/mjsunit/var.js:40: assertThrows("var \u2E2F;", SyntaxError); These two tests are identical. Did ...
6 years, 2 months ago (2014-10-04 12:20:47 UTC) #4
Diego Pino
On 2014/10/04 12:20:47, mathias wrote: > https://codereview.chromium.org/626073002/diff/1/test/mjsunit/var.js#newcode40 > test/mjsunit/var.js:40: assertThrows("var \u2E2F;", SyntaxError); > These two ...
6 years, 2 months ago (2014-10-04 13:08:27 UTC) #5
wingo
I don't much like this approach TBH. I think probably the right thing is to ...
6 years, 2 months ago (2014-10-07 10:05:10 UTC) #6
danno
6 years, 2 months ago (2014-10-07 10:45:47 UTC) #8
Yang
On 2014/10/07 10:45:47, danno wrote: I'd like to regenerate unicode.cc, preferably even to unicode 7.0.0, ...
6 years, 2 months ago (2014-10-07 10:52:59 UTC) #9
wingo
On 2014/10/07 10:52:59, Yang wrote: > can somebody point me to where this change is ...
6 years, 2 months ago (2014-10-07 11:06:50 UTC) #10
mathias
On 2014/10/07 11:06:50, wingo wrote: > On 2014/10/07 10:52:59, Yang wrote: > > can somebody ...
6 years, 2 months ago (2014-10-07 12:53:14 UTC) #11
Yang
On 2014/10/07 12:53:14, mathias wrote: > On 2014/10/07 11:06:50, wingo wrote: > > On 2014/10/07 ...
6 years, 2 months ago (2014-10-07 15:12:39 UTC) #12
Yang
On 2014/10/07 15:12:39, Yang wrote: > On 2014/10/07 12:53:14, mathias wrote: > > On 2014/10/07 ...
6 years, 2 months ago (2014-10-07 15:22:27 UTC) #13
Diego Pino
6 years, 2 months ago (2014-10-12 19:12:11 UTC) #14
Message was sent while issue was closed.
Mark as closed. Solved by https://codereview.chromium.org/638643002/.

Powered by Google App Engine
This is Rietveld 408576698