Issue 625823002: Chromecast Android buildfix: rework CommandLine initialization logic.

Issue 625823002: Chromecast Android buildfix: rework CommandLine initialization logic. (Closed)

Created:
6 years, 2 months ago by gunsch

Modified:
6 years, 2 months ago

Reviewers:
lcwu1, byungchul

CC:
chromium-reviews, lcwu+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Chromecast Android buildfix: rework CommandLine initialization logic. See: https://codereview.chromium.org/615153002 R=lcwu@chromium.org,byungchul@chromium.org BUG=None NOTRY=true Committed: https://crrev.com/65a3be162f29be44469afce8e79d635f2386e29e Cr-Commit-Position: refs/heads/master@{#298079}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -12 lines)			Patch
	M	chromecast/shell/android/apk/src/org/chromium/chromecast/shell/CastApplication.java	View		3 chunks	+19 lines, -0 lines	0 comments	Download
	M	chromecast/shell/android/apk/src/org/chromium/chromecast/shell/CastBrowserHelper.java	View		5 chunks	+2 lines, -12 lines	0 comments	Download

Total messages: 7 (1 generated)

lcwu1

On 2014/10/03 06:06:26, gunsch wrote: > One day, we'll have a trybot.... And yes, we ...

6 years, 2 months ago (2014-10-03 19:21:21 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/625823002/1

6 years, 2 months ago (2014-10-03 19:28:15 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as 4bdc2595ffea2afe8b1e0408dc2acfd813768981

6 years, 2 months ago (2014-10-03 19:29:01 UTC) #6

commit-bot: I haz the power

6 years, 2 months ago (2014-10-03 19:29:49 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/65a3be162f29be44469afce8e79d635f2386e29e
Cr-Commit-Position: refs/heads/master@{#298079}