Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Issue 615153002: Enable content layer to initCommandLine on Android (Closed)

Created:
6 years, 2 months ago by johnme
Modified:
6 years, 2 months ago
Reviewers:
cjhopman, Yaron
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, jam, haitaol+watch_chromium.org, pvalenzuela+watch_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, erikwright+watch_chromium.org, jochen+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enable content layer to initCommandLine on Android Previously, in order to initialise CommandLine, you had to know whether you were running as part of Content Shell, Chrome Shell, or Chrome, and call the corresponding method. This led to ugly code like ChromiumSyncAdapter.java having to provide an abstract initCommandLine method that gets implemented by the subclasses ChromeShellSyncAdapter.java and ChromeBrowserSyncAdapter.java. Instead this patch adds an abstract initCommandLine method on ContentApplication.java, implemented by the subclasses: - ContentShellApplication - ChromeShellApplication - ChromeMobileApplication - ChromeNativeTestApplication Thus any code in the content layer can now initialize CommandLine with: ContentApplication.initCommandLine(context); BUG=350384 TBR=fgorski@chromium.org CQ_TRYBOTS=tryserver.chromium:android_aosp,android_arm64_dbg_recipe,android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel,android_clang_dbg_recipe,android_dbg_tests_recipe Committed: https://crrev.com/c92f3e1f7b7f0bf224daf62e9512b871c4d07147 Cr-Commit-Position: refs/heads/master@{#297830}

Patch Set 1 #

Total comments: 1

Patch Set 2 : ChromiumSyncAdapterTest#testRequestSyncWhenChromeInBackground now asserts true for CommandLine.isIn… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -28 lines) Patch
M base/android/java/src/org/chromium/base/CommandLine.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/sync/ChromiumSyncAdapter.java View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/sync/ChromiumSyncAdapterTest.java View 1 6 chunks +4 lines, -9 lines 0 comments Download
M chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/shell/java/src/org/chromium/chrome/shell/sync/ChromeShellSyncAdapter.java View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/test/android/unit_tests_apk/src/org/chromium/chrome/unit_tests_apk/ChromeNativeTestApplication.java View 1 chunk +4 lines, -0 lines 0 comments Download
M components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GCMDriver.java View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/app/ContentApplication.java View 3 chunks +8 lines, -1 line 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/ContentCommandLineTest.java View 2 chunks +1 line, -2 lines 0 comments Download
M content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellActivity.java View 3 chunks +2 lines, -2 lines 0 comments Download
M content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java View 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
johnme
6 years, 2 months ago (2014-09-30 18:10:01 UTC) #2
Yaron
lgtm
6 years, 2 months ago (2014-09-30 20:09:32 UTC) #3
cjhopman
lgtm https://codereview.chromium.org/615153002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/sync/ChromiumSyncAdapterTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/sync/ChromiumSyncAdapterTest.java (left): https://codereview.chromium.org/615153002/diff/1/chrome/android/javatests/src/org/chromium/chrome/browser/sync/ChromiumSyncAdapterTest.java#oldcode48 chrome/android/javatests/src/org/chromium/chrome/browser/sync/ChromiumSyncAdapterTest.java:48: mCommandlineInitialized = true; These tests are now actually ...
6 years, 2 months ago (2014-09-30 20:40:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615153002/1
6 years, 2 months ago (2014-10-02 12:57:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/615153002/20001
6 years, 2 months ago (2014-10-02 13:52:52 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 5a5958bd17529086777a06a66588b6accdcc0524
6 years, 2 months ago (2014-10-02 14:53:00 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 14:53:39 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c92f3e1f7b7f0bf224daf62e9512b871c4d07147
Cr-Commit-Position: refs/heads/master@{#297830}

Powered by Google App Engine
This is Rietveld 408576698