Issue 625643002: [Merge] Remove unused User/Users strings from the profiles UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 625643002: [Merge] Remove unused User/Users strings from the profiles UI (Closed)

Created:
6 years, 2 months ago by noms (inactive)

Modified:
6 years, 2 months ago

Reviewers:
noms (inactive)

CC:
chromium-reviews, dbeam+watch-options_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2171

Project:
chromium

Visibility:
Public.

[Merge] Remove unused User/Users strings from the profiles UI The strings stopped being used in https://codereview.chromium.org/611033002/ XIB changes: use a different string ID for the profiles menu in the menu bar. BUG=405988 TBR=noms@chromium.org Review URL: https://codereview.chromium.org/603023004 Cr-Commit-Position: refs/heads/master@{#297422} Committed: https://chromium.googlesource.com/chromium/src/+/a55ad5888cc4a66176c7fb0e2c7b66e7a90ec615

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -52 lines)			Patch
M	chrome/app/generated_resources.grd	View	6 chunks	+1 line, -36 lines	0 comments	Download
M	chrome/app/nibs/MainMenu.xib	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/profiles/profile_menu_controller.mm	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/options/browser_options_handler.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/options/manage_profile_handler.cc	View	2 chunks	+6 lines, -8 lines	0 comments	Download

Total messages: 1 (0 generated)

noms (inactive)

6 years, 2 months ago (2014-10-02 18:21:22 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a55ad5888cc4a66176c7fb0e2c7b66e7a90ec615 (presubmit successful).