Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 603023004: Remove unused User/Users strings from the profiles UI (Closed)

Created:
6 years, 2 months ago by noms (inactive)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@people-everywhere
Project:
chromium
Visibility:
Public.

Description

Remove unused User/Users strings from the profiles UI The strings stopped being used in https://codereview.chromium.org/611033002/ XIB changes: use a different string ID for the profiles menu in the menu bar. BUG=405988 Committed: https://crrev.com/78972ce288b09e91e0e56e1a13a848c53ea3621a Cr-Commit-Position: refs/heads/master@{#297422}

Patch Set 1 #

Patch Set 2 : rebase onto master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -52 lines) Patch
M chrome/app/generated_resources.grd View 6 chunks +1 line, -36 lines 0 comments Download
M chrome/app/nibs/MainMenu.xib View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/profiles/profile_menu_controller.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/manage_profile_handler.cc View 2 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
noms (inactive)
Hiya, This is the cleanup strings CL referenced in https://codereview.chromium.org/611033002/. Please take a look. Thanks!
6 years, 2 months ago (2014-09-29 15:25:12 UTC) #2
Dan Beam
lgtm
6 years, 2 months ago (2014-09-29 18:53:27 UTC) #3
Alexei Svitkine (slow)
lgtm
6 years, 2 months ago (2014-09-29 18:55:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603023004/1
6 years, 2 months ago (2014-09-29 21:34:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/603023004/20001
6 years, 2 months ago (2014-09-30 14:10:39 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 9aaaf35d9f5d126a5faa9b47e8337c24146550ae
6 years, 2 months ago (2014-09-30 14:54:02 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 14:54:55 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/78972ce288b09e91e0e56e1a13a848c53ea3621a
Cr-Commit-Position: refs/heads/master@{#297422}

Powered by Google App Engine
This is Rietveld 408576698