Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 625513002: [ServiceWorker] pipe RequestContext and FrameType to ServiceWorker. [1/2 blink] (Closed)

Created:
6 years, 2 months ago by horo
Modified:
6 years, 2 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, mkwst+moarreviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] pipe RequestContext and FrameType to ServiceWorker. [1/2 blink] [1/2] blink: https://codereview.chromium.org/625513002/ [2/2] chromium: https://codereview.chromium.org/623663002/ BUG=411174, 418469 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183130

Patch Set 1 #

Total comments: 2

Patch Set 2 : initialize m_requestContext and m_frameType #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1 line) Patch
M Source/platform/exported/WebServiceWorkerRequest.cpp View 1 2 3 chunks +27 lines, -1 line 0 comments Download
M public/platform/WebServiceWorkerRequest.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
horo
mkwst@ Could you please review this?
6 years, 2 months ago (2014-10-02 08:36:24 UTC) #2
Mike West
LGTM % comment. Perhaps Jochen or Kent-san can OWNERS stamp the platform/ changes? https://codereview.chromium.org/625513002/diff/1/Source/platform/exported/WebServiceWorkerRequest.cpp File ...
6 years, 2 months ago (2014-10-02 08:40:52 UTC) #4
tkent
lgtm
6 years, 2 months ago (2014-10-02 08:54:05 UTC) #5
horo
Thank you! https://codereview.chromium.org/625513002/diff/1/Source/platform/exported/WebServiceWorkerRequest.cpp File Source/platform/exported/WebServiceWorkerRequest.cpp (right): https://codereview.chromium.org/625513002/diff/1/Source/platform/exported/WebServiceWorkerRequest.cpp#newcode17 Source/platform/exported/WebServiceWorkerRequest.cpp:17: : m_mode(WebURLRequest::FetchRequestModeNoCORS) On 2014/10/02 08:40:51, Mike West ...
6 years, 2 months ago (2014-10-02 09:51:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/625513002/40001
6 years, 2 months ago (2014-10-02 09:58:15 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_dbg on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/27499)
6 years, 2 months ago (2014-10-02 10:07:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/625513002/60001
6 years, 2 months ago (2014-10-02 10:34:45 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 11:38:20 UTC) #14
Message was sent while issue was closed. 
Committed patchset #3 (id:60001) as 183130

Powered by Google App Engine
This is Rietveld 408576698