Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 625293003: replace OVERRIDE and FINAL with override and final in google_apis/ (Closed)

Created:
6 years, 2 months ago by Mostyn Bramley-Moore
Modified:
6 years, 2 months ago
CC:
chromium-reviews, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

replace OVERRIDE and FINAL with override and final in google_apis/ R=rogerta@chromium.org,dcheng@chromium.org BUG=417463 Committed: https://crrev.com/80a0034deb351823d05235be94c1da161b769f28 Cr-Commit-Position: refs/heads/master@{#298418}

Patch Set 1 #

Patch Set 2 : rebase on master #

Patch Set 3 : rebase on master again #

Patch Set 4 : fake_gcm_stats_recorder.h contains windows line endings #

Patch Set 5 : another rebase on master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -282 lines) Patch
M google_apis/drive/auth_service.h View 1 chunk +10 lines, -10 lines 0 comments Download
M google_apis/drive/auth_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/drive/base_requests.h View 9 chunks +25 lines, -25 lines 0 comments Download
M google_apis/drive/base_requests_server_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/drive/base_requests_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M google_apis/drive/drive_api_requests.h View 24 chunks +47 lines, -47 lines 0 comments Download
M google_apis/drive/drive_api_requests_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/drive/dummy_auth_service.h View 1 chunk +8 lines, -8 lines 0 comments Download
M google_apis/drive/gdata_wapi_requests.h View 1 chunk +3 lines, -3 lines 0 comments Download
M google_apis/drive/gdata_wapi_requests_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/drive/request_sender_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M google_apis/gaia/account_tracker.h View 2 chunks +9 lines, -9 lines 0 comments Download
M google_apis/gaia/account_tracker_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M google_apis/gaia/fake_identity_provider.h View 1 chunk +4 lines, -4 lines 0 comments Download
M google_apis/gaia/fake_oauth2_token_service.h View 3 chunks +6 lines, -6 lines 0 comments Download
M google_apis/gaia/gaia_auth_fetcher.h View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/gaia_oauth_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/gaia_oauth_client_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M google_apis/gaia/identity_provider.h View 1 chunk +3 lines, -3 lines 0 comments Download
M google_apis/gaia/merge_session_helper.h View 3 chunks +7 lines, -7 lines 0 comments Download
M google_apis/gaia/mock_url_fetcher_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M google_apis/gaia/oauth2_access_token_fetcher_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M google_apis/gaia/oauth2_api_call_flow.h View 1 chunk +3 lines, -3 lines 0 comments Download
M google_apis/gaia/oauth2_mint_token_flow.h View 1 chunk +6 lines, -6 lines 0 comments Download
M google_apis/gaia/oauth2_token_service.h View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/oauth2_token_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gaia/oauth2_token_service_request.h View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/oauth2_token_service_request.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M google_apis/gaia/oauth2_token_service_request_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M google_apis/gaia/oauth2_token_service_test_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gaia/oauth2_token_service_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M google_apis/gaia/ubertoken_fetcher.h View 1 chunk +4 lines, -4 lines 0 comments Download
M google_apis/gaia/ubertoken_fetcher_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M google_apis/gcm/base/fake_encryptor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M google_apis/gcm/base/socket_stream.h View 2 chunks +7 lines, -7 lines 0 comments Download
M google_apis/gcm/engine/checkin_request.h View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/connection_factory_impl.h View 1 chunk +9 lines, -9 lines 0 comments Download
M google_apis/gcm/engine/connection_factory_impl_unittest.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M google_apis/gcm/engine/connection_handler_impl.h View 1 chunk +4 lines, -4 lines 0 comments Download
M google_apis/gcm/engine/fake_connection_factory.h View 1 chunk +8 lines, -8 lines 0 comments Download
M google_apis/gcm/engine/fake_connection_handler.h View 1 chunk +4 lines, -4 lines 0 comments Download
M google_apis/gcm/engine/gcm_store_impl.h View 1 chunk +17 lines, -17 lines 0 comments Download
M google_apis/gcm/engine/mcs_client_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M google_apis/gcm/engine/registration_request.h View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/engine/unregistration_request.h View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gcm/monitoring/fake_gcm_stats_recorder.h View 1 2 3 4 1 chunk +19 lines, -19 lines 0 comments Download
M google_apis/gcm/tools/mcs_probe.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (5 generated)
Mostyn Bramley-Moore
@Roger: can you give this a thumbs-up? The script I used to make this change ...
6 years, 2 months ago (2014-10-06 14:43:57 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm When will we remove the virtual keyword?
6 years, 2 months ago (2014-10-06 15:30:52 UTC) #2
Mostyn Bramley-Moore
On 2014/10/06 15:30:52, Roger Tawa wrote: > lgtm > > When will we remove the ...
6 years, 2 months ago (2014-10-06 15:32:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/625293003/20001
6 years, 2 months ago (2014-10-06 15:35:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/75275) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/64664) win_gpu ...
6 years, 2 months ago (2014-10-06 15:40:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/625293003/2
6 years, 2 months ago (2014-10-06 16:08:51 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/75302) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/64693) android_aosp ...
6 years, 2 months ago (2014-10-06 16:15:53 UTC) #11
Mostyn Bramley-Moore
I'm not sure what's going wrong here- I have tried rebasing this CL on master ...
6 years, 2 months ago (2014-10-06 16:54:53 UTC) #12
Roger Tawa OOO till Jul 10th
On 2014/10/06 16:54:53, Mostyn Bramley-Moore wrote: > I'm not sure what's going wrong here- I ...
6 years, 2 months ago (2014-10-06 19:22:58 UTC) #13
Mostyn Bramley-Moore
On 2014/10/06 19:22:58, Roger Tawa wrote: > On 2014/10/06 16:54:53, Mostyn Bramley-Moore wrote: > > ...
6 years, 2 months ago (2014-10-06 21:30:46 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/625293003/70001
6 years, 2 months ago (2014-10-07 06:27:44 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:70001) as 27d92991fe1549467e7229553e6f4ed50d69cd05
6 years, 2 months ago (2014-10-07 07:43:52 UTC) #17
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 07:44:46 UTC) #18
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/80a0034deb351823d05235be94c1da161b769f28
Cr-Commit-Position: refs/heads/master@{#298418}

Powered by Google App Engine
This is Rietveld 408576698