tools/telemetry/telemetry/page/page_set.py - Issue 625123002: Make credential_path a page attribute instead of page_set attribute.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page/page_set.py

Issue 625123002: Make credential_path a page attribute instead of page_set attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert changes to path & path_unittest Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/page/page_runner_unittest.py ('k') | tools/telemetry/telemetry/unittest/page_set_smoke_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/page/page_set.py

diff --git a/tools/telemetry/telemetry/page/page_set.py b/tools/telemetry/telemetry/page/page_set.py

index a3b40acd5de1292fd3808398d9e23a9bccb850f6..ce4a67549ba47c320708039b4b9dbd1192b355a7 100644

--- a/tools/telemetry/telemetry/page/page_set.py

+++ b/tools/telemetry/telemetry/page/page_set.py

@@ -21,8 +21,7 @@ class PageSetError(Exception):

class PageSet(user_story_set.UserStorySet):

- def __init__(self, file_path=None, archive_data_file='',

- credentials_path=None, user_agent_type=None,

+ def __init__(self, file_path=None, archive_data_file='', user_agent_type=None,

make_javascript_deterministic=True, startup_url='',

serving_dirs=None, bucket=None):

super(PageSet, self).__init__()

@@ -37,7 +36,6 @@ class PageSet(user_story_set.UserStorySet):

self.file_path = file_path

# These attributes can be set dynamically by the page set.

self.archive_data_file = archive_data_file

- self.credentials_path = credentials_path

self.user_agent_type = user_agent_type

self.make_javascript_deterministic = make_javascript_deterministic

self._wpr_archive_info = None