Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: tools/telemetry/telemetry/page/page_runner_unittest.py

Issue 625123002: Make credential_path a page attribute instead of page_set attribute. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert changes to path & path_unittest Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/page/page_runner.py ('k') | tools/telemetry/telemetry/page/page_set.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/page/page_runner_unittest.py
diff --git a/tools/telemetry/telemetry/page/page_runner_unittest.py b/tools/telemetry/telemetry/page/page_runner_unittest.py
index 7613b565870a4f467cca71696e89fc1e16614985..894c84f8da3a07484ad61f7a6a42fce479dc5910 100644
--- a/tools/telemetry/telemetry/page/page_runner_unittest.py
+++ b/tools/telemetry/telemetry/page/page_runner_unittest.py
@@ -329,17 +329,17 @@ class PageRunnerTests(unittest.TestCase):
def runCredentialsTest(self, credentials_backend):
ps = page_set.PageSet()
expectations = test_expectations.TestExpectations()
- page = page_module.Page(
- 'file://blank.html', ps, base_dir=util.GetUnittestDataDir())
- page.credentials = "test"
- ps.pages.append(page)
-
did_run = [False]
try:
with tempfile.NamedTemporaryFile(delete=False) as f:
+ page = page_module.Page(
+ 'file://blank.html', ps, base_dir=util.GetUnittestDataDir(),
+ credentials_path=f.name)
+ page.credentials = "test"
+ ps.pages.append(page)
+
f.write(SIMPLE_CREDENTIALS_STRING)
- ps.credentials_path = f.name
class TestThatInstallsCredentialsBackend(page_test.PageTest):
def __init__(self, credentials_backend):
« no previous file with comments | « tools/telemetry/telemetry/page/page_runner.py ('k') | tools/telemetry/telemetry/page/page_set.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698