Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 625013002: Only send ViewHostMsg_FocusedNodeTouched on Windows (Closed)

Created:
6 years, 2 months ago by jdduke (slow)
Modified:
6 years, 2 months ago
Reviewers:
jam
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Only send ViewHostMsg_FocusedNodeTouched on Windows This message is only handled on Windows, and should only be sent on Windows. The longer term solution will involve removing it entirely, but in the meantime disable its dispatch on all other platforms. BUG=420130 Committed: https://crrev.com/45762d28d013c5c985da49eef8d09ca30330012f Cr-Commit-Position: refs/heads/master@{#298368}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M content/renderer/render_view_impl.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
jdduke (slow)
jam@: PTAL. I have a follow-up patch (https://codereview.chromium.org/626983002) that removes the message entirely, but it ...
6 years, 2 months ago (2014-10-03 17:59:13 UTC) #2
jdduke (slow)
On 2014/10/03 17:59:13, jdduke wrote: > jam@: PTAL. I have a follow-up patch (https://codereview.chromium.org/626983002) > ...
6 years, 2 months ago (2014-10-03 18:01:35 UTC) #3
jam
lgtm
6 years, 2 months ago (2014-10-06 23:27:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/625013002/1
6 years, 2 months ago (2014-10-07 00:15:52 UTC) #6
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 2 months ago (2014-10-07 02:23:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/625013002/1
6 years, 2 months ago (2014-10-07 04:05:20 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as 7a09416e1338272f8f171aa937147ccb729c13c0
6 years, 2 months ago (2014-10-07 04:19:16 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 04:20:38 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/45762d28d013c5c985da49eef8d09ca30330012f
Cr-Commit-Position: refs/heads/master@{#298368}

Powered by Google App Engine
This is Rietveld 408576698