Issue 624643002: Merge to branch 2171 [Password Generation] Fix a bug where we always upload ACCOUNT_CREATION_PASSWO…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 624643002: Merge to branch 2171 [Password Generation] Fix a bug where we always upload ACCOUNT_CREATION_PASSWO… (Closed)

Created:
6 years, 2 months ago by Garrett Casto

Modified:
6 years, 2 months ago

Reviewers:
Ilya Sherman

CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2171

Project:
chromium

Visibility:
Public.

Merge to branch 2171 [Password Generation] Fix a bug where we always upload ACCOUNT_CREATION_PASSWORD Update test to catch the problem. Previous test mocked out bad behavior. BUG=419228 R=isherman@chromium.org Review URL: https://codereview.chromium.org/614313002 Cr-Commit-Position: refs/heads/master@{#297580} (cherry picked from commit 44c5e4ebc358b6e804ae7af97fd240ca5682743f) Committed: https://chromium.googlesource.com/chromium/src/+/ed643705547bf2c2894b73b4c78e9541a969ffda

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	components/password_manager/core/browser/password_form_manager.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 1 (0 generated)

Garrett Casto

6 years, 2 months ago (2014-10-02 18:57:29 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ed643705547bf2c2894b73b4c78e9541a969ffda.