Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: components/password_manager/core/browser/password_form_manager.cc

Issue 624643002: Merge to branch 2171 [Password Generation] Fix a bug where we always upload ACCOUNT_CREATION_PASSWO… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2171
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_form_manager.cc
diff --git a/components/password_manager/core/browser/password_form_manager.cc b/components/password_manager/core/browser/password_form_manager.cc
index 59eff7cc5235d839e224c9b1fa90916d4553389f..5bd25b61e3330690e346462d51e8b0a7267bf3c7 100644
--- a/components/password_manager/core/browser/password_form_manager.cc
+++ b/components/password_manager/core/browser/password_form_manager.cc
@@ -730,8 +730,7 @@ void PasswordFormManager::UploadPasswordForm(
// Note that this doesn't guarantee that the upload succeeded, only that
// |form_data| is considered uploadable.
bool success =
- autofill_manager->UploadPasswordForm(
- form_data, autofill::ACCOUNT_CREATION_PASSWORD);
+ autofill_manager->UploadPasswordForm(form_data, password_type);
UMA_HISTOGRAM_BOOLEAN("PasswordGeneration.UploadStarted", success);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698