Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 624533003: Check that the user doesn't try to run ASan-built binaries under Valgrind etc (Closed)

Created:
6 years, 2 months ago by Timur Iskhodzhanov
Modified:
6 years, 2 months ago
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org, ygorshenin1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Check that the user doesn't try to run ASan-built binaries under Valgrind etc R=glider@chromium.org NOTRY=true Committed: https://crrev.com/624be8ed861888e0ef75e7e90881363eaa6213f8 Cr-Commit-Position: refs/heads/master@{#297836}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : Try #

Total comments: 2

Patch Set 4 : address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -57 lines) Patch
D tools/valgrind/asan/asan_wrapper.sh View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
M tools/valgrind/chrome_tests.py View 1 2 3 3 chunks +23 lines, -1 line 0 comments Download
M tools/valgrind/valgrind_test.py View 1 2 2 chunks +0 lines, -40 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Timur Iskhodzhanov
6 years, 2 months ago (2014-10-02 13:09:02 UTC) #1
Alexander Potapenko
https://codereview.chromium.org/624533003/diff/20001/tools/valgrind/chrome_tests.py File tools/valgrind/chrome_tests.py (right): https://codereview.chromium.org/624533003/diff/20001/tools/valgrind/chrome_tests.py#newcode129 tools/valgrind/chrome_tests.py:129: if subprocess.call(["which", "nm"]) == 0: just wrapping subprocess.check_output() into ...
6 years, 2 months ago (2014-10-02 13:19:08 UTC) #2
Timur Iskhodzhanov
PTAL
6 years, 2 months ago (2014-10-02 14:05:48 UTC) #3
Alexander Potapenko
lgtm https://codereview.chromium.org/624533003/diff/40001/tools/valgrind/chrome_tests.py File tools/valgrind/chrome_tests.py (right): https://codereview.chromium.org/624533003/diff/40001/tools/valgrind/chrome_tests.py#newcode129 tools/valgrind/chrome_tests.py:129: # if `nm` is available. I think this ...
6 years, 2 months ago (2014-10-02 15:19:49 UTC) #4
Alexander Potapenko
lgtm
6 years, 2 months ago (2014-10-02 15:19:50 UTC) #5
Alexander Potapenko
On 2014/10/02 15:19:50, Alexander Potapenko wrote: > lgtm PS4 also looks good.
6 years, 2 months ago (2014-10-02 15:23:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/624533003/2
6 years, 2 months ago (2014-10-02 15:24:06 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:2) as c870526b075a6f1b2744829c634975a5af731531
6 years, 2 months ago (2014-10-02 15:25:24 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 15:26:08 UTC) #12
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/624be8ed861888e0ef75e7e90881363eaa6213f8
Cr-Commit-Position: refs/heads/master@{#297836}

Powered by Google App Engine
This is Rietveld 408576698