Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: tools/valgrind/valgrind_test.py

Issue 624533003: Check that the user doesn't try to run ASan-built binaries under Valgrind etc (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address review comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/valgrind/chrome_tests.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/valgrind/valgrind_test.py
diff --git a/tools/valgrind/valgrind_test.py b/tools/valgrind/valgrind_test.py
index 29903d91629e6cb2a5242bffd3ba26ea73f993aa..f568b5e8695df3bd56c98ee906a3239bf19350bb 100644
--- a/tools/valgrind/valgrind_test.py
+++ b/tools/valgrind/valgrind_test.py
@@ -1165,44 +1165,6 @@ class RaceVerifier(object):
return self.Main(args, False, min_runtime_in_seconds)
-class EmbeddedTool(BaseTool):
- """Abstract class for tools embedded directly into the test binary.
- """
- # TODO(glider): need to override Execute() and support process chaining here.
-
- def ToolCommand(self):
- # In the simplest case just the args of the script.
- return self._args
-
-
-class Asan(EmbeddedTool):
- """AddressSanitizer, a memory error detector.
-
- More information at
- http://dev.chromium.org/developers/testing/addresssanitizer
- """
- def __init__(self):
- super(Asan, self).__init__()
- self._timeout = 1200
- if common.IsMac():
- self._env["DYLD_NO_PIE"] = "1"
-
-
- def ToolName(self):
- return "asan"
-
- def ToolCommand(self):
- # TODO(glider): use pipes instead of the ugly wrapper here once they
- # are supported.
- procs = [os.path.join(self._source_dir, "tools", "valgrind",
- "asan", "asan_wrapper.sh")]
- procs.extend(self._args)
- return procs
-
- def Analyze(sels, unused_check_sanity):
- return 0
-
-
class ToolFactory:
def Create(self, tool_name):
if tool_name == "memcheck":
@@ -1223,8 +1185,6 @@ class ToolFactory:
return DrMemory(False, True)
if tool_name == "tsan_rv":
return RaceVerifier()
- if tool_name == "asan":
- return Asan()
try:
platform_name = common.PlatformNames()[0]
except common.NotImplementedError:
« no previous file with comments | « tools/valgrind/chrome_tests.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698