Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 624513002: Make MIME boundary harder to accidentally match. (Closed)

Created:
6 years, 2 months ago by jrobbins
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Using this code to upload this patch #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M appengine/chromium_rietveld/upload.py View 1 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 9 (4 generated)
jrobbins
PTAL.
6 years, 2 months ago (2014-10-01 22:13:09 UTC) #2
iannucci
On 2014/10/01 22:13:09, Jason Robbins wrote: > PTAL. Couldn't we take the hash of all ...
6 years, 2 months ago (2014-10-02 02:10:00 UTC) #3
Jason Robbins -- corp
OK, using hash now.
6 years, 2 months ago (2014-10-02 17:37:08 UTC) #5
jrobbins
Committed patchset #3 (id:40001) manually as b43935f58581968f4b3597923f6b5d00baaf618c.
6 years, 2 months ago (2014-10-06 15:38:37 UTC) #8
iannucci
6 years, 2 months ago (2014-10-13 18:19:16 UTC) #9
Message was sent while issue was closed. 
oops, never published this comment. oh well, it probably doesn't really matter

https://codereview.chromium.org/624513002/diff/40001/appengine/chromium_rietv...
File appengine/chromium_rietveld/upload.py (right):

https://codereview.chromium.org/624513002/diff/40001/appengine/chromium_rietv...
appengine/chromium_rietveld/upload.py:976: BOUNDARY =
'-M-A-G-I-C---B-O-U-N-D-A-R-Y-%s-' % sum(hash(f) for f in files)
oh... I was meaning a real crypographic hash over the file contents. Not sure
what the properties of this construction are. Either patch lgtm though.

Powered by Google App Engine
This is Rietveld 408576698