appengine/chromium_rietveld/upload.py - Issue 624513002: Make MIME boundary harder to accidentally match.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/chromium_rietveld/upload.py

Issue 624513002: Make MIME boundary harder to accidentally match. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Using this code to upload this patch Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/chromium_rietveld/upload.py

diff --git a/appengine/chromium_rietveld/upload.py b/appengine/chromium_rietveld/upload.py

index 8f22fcb1cfa32845ec9c81a1d3a414f447d057f9..2647a0fde0de73c8b0012f0f53fbe7b963287501 100755

--- a/appengine/chromium_rietveld/upload.py

+++ b/appengine/chromium_rietveld/upload.py

@@ -973,7 +973,7 @@ def EncodeMultipartFormData(fields, files):

Source:

http://aspn.activestate.com/ASPN/Cookbook/Python/Recipe/146306

"""

- BOUNDARY = '-M-A-G-I-C---B-O-U-N-D-A-R-Y-'

+ BOUNDARY = '-M-A-G-I-C---B-O-U-N-D-A-R-Y-%s-' % sum(hash(f) for f in files)

iannucci 2014/10/13 18:19:16 oh... I was meaning a real crypographic hash over

CRLF = '\r\n'

lines = []

for (key, value) in fields:

« no previous file with comments | « no previous file | no next file » | no next file with comments »