Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4881)

Unified Diff: chrome/common/extensions/api/extension_action/browser_action_handler.cc

Issue 624453003: Clean up Extension Action Handlers Pt 1/2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/extension_action/browser_action_handler.cc
diff --git a/chrome/common/extensions/api/extension_action/browser_action_handler.cc b/chrome/common/extensions/api/extension_action/browser_action_handler.cc
deleted file mode 100644
index af9a80fbc2f4dcf0b50a999779afeb8abba62f0f..0000000000000000000000000000000000000000
--- a/chrome/common/extensions/api/extension_action/browser_action_handler.cc
+++ /dev/null
@@ -1,63 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/common/extensions/api/extension_action/browser_action_handler.h"
-
-#include "base/memory/scoped_ptr.h"
-#include "base/strings/utf_string_conversions.h"
-#include "base/values.h"
-#include "chrome/grit/generated_resources.h"
-#include "extensions/common/extension.h"
-#include "extensions/common/feature_switch.h"
-#include "extensions/common/file_util.h"
-#include "extensions/common/manifest.h"
-#include "extensions/common/manifest_constants.h"
-
-namespace extensions {
-
-BrowserActionHandler::BrowserActionHandler() {
-}
-
-BrowserActionHandler::~BrowserActionHandler() {
-}
-
-bool BrowserActionHandler::Parse(Extension* extension,
- base::string16* error) {
- const base::DictionaryValue* dict = NULL;
- if (!extension->manifest()->GetDictionary(
- manifest_keys::kBrowserAction, &dict)) {
- *error = base::ASCIIToUTF16(manifest_errors::kInvalidBrowserAction);
- return false;
- }
-
- scoped_ptr<ActionInfo> action_info = ActionInfo::Load(extension, dict, error);
- if (!action_info.get())
- return false; // Failed to parse browser action definition.
-
- ActionInfo::SetBrowserActionInfo(extension, action_info.release());
-
- return true;
-}
-
-bool BrowserActionHandler::Validate(
- const Extension* extension,
- std::string* error,
- std::vector<InstallWarning>* warnings) const {
- const ActionInfo* action = ActionInfo::GetBrowserActionInfo(extension);
- if (action && !action->default_icon.empty() &&
- !file_util::ValidateExtensionIconSet(
- action->default_icon,
- extension,
- IDS_EXTENSION_LOAD_ICON_FOR_BROWSER_ACTION_FAILED,
- error)) {
- return false;
- }
- return true;
-}
-
-const std::vector<std::string> BrowserActionHandler::Keys() const {
- return SingleKey(manifest_keys::kBrowserAction);
-}
-
-} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698