Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1069)

Unified Diff: content/browser/renderer_host/input/synthetic_smooth_scroll_gesture.cc

Issue 62443007: Replace old with new synthetic gesture framework. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Forward declare SyntheticGestureController. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/input/synthetic_smooth_scroll_gesture.cc
diff --git a/content/browser/renderer_host/input/synthetic_smooth_scroll_gesture_new.cc b/content/browser/renderer_host/input/synthetic_smooth_scroll_gesture.cc
similarity index 67%
rename from content/browser/renderer_host/input/synthetic_smooth_scroll_gesture_new.cc
rename to content/browser/renderer_host/input/synthetic_smooth_scroll_gesture.cc
index 56402942cf4825e424ca1540b11f50230b7a0e89..89b12a87045ab0349c8505e12ab529b54da02c8e 100644
--- a/content/browser/renderer_host/input/synthetic_smooth_scroll_gesture_new.cc
+++ b/content/browser/renderer_host/input/synthetic_smooth_scroll_gesture.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "content/browser/renderer_host/input/synthetic_smooth_scroll_gesture_new.h"
+#include "content/browser/renderer_host/input/synthetic_smooth_scroll_gesture.h"
#include <cmath>
@@ -11,14 +11,13 @@
namespace content {
-SyntheticSmoothScrollGestureNew::SyntheticSmoothScrollGestureNew(
+SyntheticSmoothScrollGesture::SyntheticSmoothScrollGesture(
const SyntheticSmoothScrollGestureParams& params)
- : params_(params),
- current_y_(params_.anchor.y()) {}
+ : params_(params), current_y_(params_.anchor.y()) {}
-SyntheticSmoothScrollGestureNew::~SyntheticSmoothScrollGestureNew() {}
+SyntheticSmoothScrollGesture::~SyntheticSmoothScrollGesture() {}
-SyntheticGestureNew::Result SyntheticSmoothScrollGestureNew::ForwardInputEvents(
+SyntheticGesture::Result SyntheticSmoothScrollGesture::ForwardInputEvents(
const base::TimeDelta& interval, SyntheticGestureTarget* target) {
SyntheticGestureParams::GestureSourceType source =
@@ -27,21 +26,20 @@ SyntheticGestureNew::Result SyntheticSmoothScrollGestureNew::ForwardInputEvents(
source = target->GetDefaultSyntheticGestureSourceType();
if (!target->SupportsSyntheticGestureSourceType(source))
- return SyntheticGestureNew::GESTURE_SOURCE_TYPE_NOT_SUPPORTED_BY_PLATFORM;
+ return SyntheticGesture::GESTURE_SOURCE_TYPE_NOT_SUPPORTED_BY_PLATFORM;
if (source == SyntheticGestureParams::TOUCH_INPUT)
return ForwardTouchInputEvents(interval, target);
else if (source == SyntheticGestureParams::MOUSE_INPUT)
return ForwardMouseInputEvents(interval, target);
else
- return SyntheticGestureNew::GESTURE_SOURCE_TYPE_NOT_IMPLEMENTED;
+ return SyntheticGesture::GESTURE_SOURCE_TYPE_NOT_IMPLEMENTED;
}
-SyntheticGestureNew::Result
-SyntheticSmoothScrollGestureNew::ForwardTouchInputEvents(
+SyntheticGesture::Result SyntheticSmoothScrollGesture::ForwardTouchInputEvents(
const base::TimeDelta& interval, SyntheticGestureTarget* target) {
if (HasFinished())
- return SyntheticGestureNew::GESTURE_FINISHED;
+ return SyntheticGesture::GESTURE_FINISHED;
if (current_y_ == params_.anchor.y()) {
touch_event_.PressPoint(params_.anchor.x(), current_y_);
@@ -55,38 +53,35 @@ SyntheticSmoothScrollGestureNew::ForwardTouchInputEvents(
if (HasFinished()) {
touch_event_.ReleasePoint(0);
ForwardTouchEvent(target);
- return SyntheticGestureNew::GESTURE_FINISHED;
- }
- else {
- return SyntheticGestureNew::GESTURE_RUNNING;
+ return SyntheticGesture::GESTURE_FINISHED;
}
+
+ return SyntheticGesture::GESTURE_RUNNING;
}
-SyntheticGestureNew::Result
-SyntheticSmoothScrollGestureNew::ForwardMouseInputEvents(
+SyntheticGesture::Result SyntheticSmoothScrollGesture::ForwardMouseInputEvents(
const base::TimeDelta& interval, SyntheticGestureTarget* target) {
if (HasFinished())
- return SyntheticGestureNew::GESTURE_FINISHED;
+ return SyntheticGesture::GESTURE_FINISHED;
float delta = GetPositionDelta(interval);
current_y_ += delta;
ForwardMouseWheelEvent(target, delta);
if (HasFinished())
- return SyntheticGestureNew::GESTURE_FINISHED;
- else
- return SyntheticGestureNew::GESTURE_RUNNING;
+ return SyntheticGesture::GESTURE_FINISHED;
+
+ return SyntheticGesture::GESTURE_RUNNING;
}
-void SyntheticSmoothScrollGestureNew::ForwardTouchEvent(
+void SyntheticSmoothScrollGesture::ForwardTouchEvent(
SyntheticGestureTarget* target) {
target->DispatchInputEventToPlatform(
InputEvent(touch_event_, ui::LatencyInfo(), false));
}
-void SyntheticSmoothScrollGestureNew::ForwardMouseWheelEvent(
- SyntheticGestureTarget* target,
- float delta) {
+void SyntheticSmoothScrollGesture::ForwardMouseWheelEvent(
+ SyntheticGestureTarget* target, float delta) {
blink::WebMouseWheelEvent mouse_wheel_event =
SyntheticWebMouseWheelEventBuilder::Build(0, delta, 0, false);
@@ -94,7 +89,7 @@ void SyntheticSmoothScrollGestureNew::ForwardMouseWheelEvent(
InputEvent(mouse_wheel_event, ui::LatencyInfo(), false));
}
-float SyntheticSmoothScrollGestureNew::GetPositionDelta(
+float SyntheticSmoothScrollGesture::GetPositionDelta(
const base::TimeDelta& interval) {
float delta = params_.speed_in_pixels_s * interval.InSecondsF();
// A positive value indicates scrolling down, which means the touch pointer
@@ -103,7 +98,7 @@ float SyntheticSmoothScrollGestureNew::GetPositionDelta(
return (params_.distance > 0) ? -delta : delta;
}
-bool SyntheticSmoothScrollGestureNew::HasFinished() {
+bool SyntheticSmoothScrollGesture::HasFinished() {
return abs(current_y_ - params_.anchor.y()) >= abs(params_.distance);
}

Powered by Google App Engine
This is Rietveld 408576698