Replace old with new synthetic gesture framework.

content/browser/renderer_host/input/synthetic_gesture.cc

Index: content/browser/renderer_host/input/synthetic_gesture.cc
diff --git a/content/browser/renderer_host/input/synthetic_gesture_new.cc b/content/browser/renderer_host/input/synthetic_gesture.cc
similarity index 67%
rename from content/browser/renderer_host/input/synthetic_gesture_new.cc
rename to content/browser/renderer_host/input/synthetic_gesture.cc
index 3812504367cfe3141570d0720aa3f95f152f5371..9b57168dcd1d495d2f40fc2ae6955023dd40eb6b 100644
--- a/content/browser/renderer_host/input/synthetic_gesture_new.cc
+++ b/content/browser/renderer_host/input/synthetic_gesture.cc
@@ -2,40 +2,40 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "content/browser/renderer_host/input/synthetic_gesture_new.h"
+#include "content/browser/renderer_host/input/synthetic_gesture.h"
 
 #include "content/browser/renderer_host/input/synthetic_gesture_target.h"
-#include "content/browser/renderer_host/input/synthetic_pinch_gesture_new.h"
-#include "content/browser/renderer_host/input/synthetic_smooth_scroll_gesture_new.h"
+#include "content/browser/renderer_host/input/synthetic_pinch_gesture.h"
+#include "content/browser/renderer_host/input/synthetic_smooth_scroll_gesture.h"
 
 namespace content {
 namespace {
 
 template <typename GestureType, typename GestureParamsType>
-static scoped_ptr<SyntheticGestureNew> CreateGesture(
+static scoped_ptr<SyntheticGesture> CreateGesture(
     const SyntheticGestureParams& gesture_params) {
-  return scoped_ptr<SyntheticGestureNew>(
+  return scoped_ptr<SyntheticGesture>(
       new GestureType(*GestureParamsType::Cast(&gesture_params)));
 }
 
 }  // namespace
 
-SyntheticGestureNew::SyntheticGestureNew() {}
+SyntheticGesture::SyntheticGesture() {}
 
-SyntheticGestureNew::~SyntheticGestureNew() {}
+SyntheticGesture::~SyntheticGesture() {}
 
-scoped_ptr<SyntheticGestureNew> SyntheticGestureNew::Create(
+scoped_ptr<SyntheticGesture> SyntheticGesture::Create(
     const SyntheticGestureParams& gesture_params) {
   switch (gesture_params.GetGestureType()) {
     case SyntheticGestureParams::SMOOTH_SCROLL_GESTURE:
-      return CreateGesture<SyntheticSmoothScrollGestureNew,
+      return CreateGesture<SyntheticSmoothScrollGesture,
                            SyntheticSmoothScrollGestureParams>(gesture_params);
     case SyntheticGestureParams::PINCH_GESTURE:
-      return CreateGesture<SyntheticPinchGestureNew,
+      return CreateGesture<SyntheticPinchGesture,

[kenrb, 2013/11/19 15:43:08]

I realize this isn't specific to your patch, but I have a question about how
SyntheticGestureParams get cast to their subtypes. They self-identify which type
they are, but I can't see any way by which we guarantee that have the correct
size. I'm concerned that a renderer process passing these messages could supply
too little data, have it's params cast to a gesture type, and then use this as a
memory leak primitive.

[Dominik Grewe, 2013/11/19 17:10:28]

How could we check the size of the data? The message we send contains a
SyntheticGesturePacket which points to the SyntheticGestureParams. So we'd have
to check the size of that object pointed to by the packet, rather than the
message itself, right? How can we do that at runtime?

                            SyntheticPinchGestureParams>(gesture_params);
   }
   NOTREACHED() << "Invalid synthetic gesture type";
-  return scoped_ptr<SyntheticGestureNew>();
+  return scoped_ptr<SyntheticGesture>();
 }
 
 }  // namespace content