content/renderer/browser_plugin/browser_plugin.h - Issue 624063002: <webview>: resizing with display:none set should resize on attachment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/browser_plugin/browser_plugin.h

Issue 624063002: <webview>: resizing with display:none set should resize on attachment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Istiaque's comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/renderer/browser_plugin_delegate.h ('k') | content/renderer/browser_plugin/browser_plugin.cc » ('j') | extensions/renderer/guest_view/guest_view_container.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/browser_plugin/browser_plugin.h

diff --git a/content/renderer/browser_plugin/browser_plugin.h b/content/renderer/browser_plugin/browser_plugin.h

index 1ee6992b5fa6e1a0a6b54b006aa0fee20e9804cb..b25f5593e800f6467863866abb6b1ace4a8aa472 100644

--- a/content/renderer/browser_plugin/browser_plugin.h

+++ b/content/renderer/browser_plugin/browser_plugin.h

@@ -207,6 +207,9 @@ class CONTENT_EXPORT BrowserPlugin :

bool mouse_locked_;

+ // This indicates that the BrowserPlugin has a geometry.

+ bool ready_;

// BrowserPlugin outlives RenderViewImpl in Chrome Apps and so we need to

// store the BrowserPlugin's BrowserPluginManager in a member variable to

// avoid accessing the RenderViewImpl.