content/renderer/browser_plugin/browser_plugin.cc - Issue 624063002: <webview>: resizing with display:none set should resize on attachment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/browser_plugin/browser_plugin.cc

Issue 624063002: <webview>: resizing with display:none set should resize on attachment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Istiaque's comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/browser_plugin/browser_plugin.h ('k') | extensions/renderer/guest_view/guest_view_container.h » ('j') | extensions/renderer/guest_view/guest_view_container.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/browser_plugin/browser_plugin.cc

diff --git a/content/renderer/browser_plugin/browser_plugin.cc b/content/renderer/browser_plugin/browser_plugin.cc

index 7e91f85cc05af6ec95895039c4c96b3911b6bbf4..0f03c3df5f056e4dd790b7b63bf76cacb2d79a50 100644

--- a/content/renderer/browser_plugin/browser_plugin.cc

+++ b/content/renderer/browser_plugin/browser_plugin.cc

@@ -70,6 +70,7 @@ BrowserPlugin::BrowserPlugin(RenderViewImpl* render_view,

plugin_focused_(false),

visible_(true),

mouse_locked_(false),

+ ready_(false),

browser_plugin_manager_(render_view->GetBrowserPluginManager()),

browser_plugin_instance_id_(browser_plugin::kInstanceIDNone),

contents_opaque_(true),

@@ -433,6 +434,11 @@ void BrowserPlugin::updateGeometry(

int old_width = width();

int old_height = height();

plugin_rect_ = window_rect;

+ if (!ready_) {

+ if (delegate_)

+ delegate_->Ready();

+ ready_ = true;

+ }

if (!attached())

return;